Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soundness problem when matching iso variables #4588

Merged
merged 15 commits into from
Jan 25, 2025
Merged

Fix soundness problem when matching iso variables #4588

merged 15 commits into from
Jan 25, 2025

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Jan 18, 2025

Closes #4579

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 18, 2025
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jan 18, 2025
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4588.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen changed the title Issue 4579 Fix soundness problem when matching iso variables Jan 22, 2025
@SeanTAllen
Copy link
Member Author

@jemc will be pushing a change with a couple tests added and then this is ready to go.

@SeanTAllen SeanTAllen marked this pull request as ready for review January 25, 2025 01:02
@SeanTAllen SeanTAllen merged commit edc09e6 into main Jan 25, 2025
26 checks passed
@SeanTAllen SeanTAllen deleted the issue-4579 branch January 25, 2025 20:46
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 25, 2025
github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
SeanTAllen added a commit to ponylang/http that referenced this pull request Jan 26, 2025
A small bit of code no longer works after
ponylang/ponyc#4588 was merged.

This fix gets the library working again.
SeanTAllen added a commit to ponylang/http that referenced this pull request Jan 26, 2025
A small bit of code no longer works after
ponylang/ponyc#4588 was merged.

This fix gets the library working again.
SeanTAllen added a commit to ponylang/http that referenced this pull request Jan 26, 2025
A small bit of code no longer works after
ponylang/ponyc#4588 was merged.

This fix gets the library working again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect aliasing of iso when using match
3 participants