Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize CI sanitizers pull request job #4596

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

SeanTAllen
Copy link
Member

No description provided.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 24, 2025
@SeanTAllen
Copy link
Member Author

@SeanTAllen SeanTAllen requested a review from dipinhora January 24, 2025 13:04
@dipinhora
Copy link
Contributor

@SeanTAllen the leak detector is what generates all the extra output.. it's happening because the CI build in this PR is running:

  make configure arch=x86-64 config=debug use=pool_memalign,address_sanitizer,undefined_behavior_sanitizer
  make build config=debug

instead of:

  ASAN_OPTIONS=detect_leaks=0:external_symbolizer_path=$PWD/build/libs/bin/llvm-symbolizer UBSAN_OPTIONS=external_symbolizer_path=$PWD/build/libs/bin/llvm-symbolizer make configure arch=x86-64 config=debug use=pool_memalign,address_sanitizer,undefined_behavior_sanitizer
  ASAN_OPTIONS=detect_leaks=0:external_symbolizer_path=$PWD/build/libs/bin/llvm-symbolizer UBSAN_OPTIONS=external_symbolizer_path=$PWD/build/libs/bin/llvm-symbolizer make build config=debug

the missing ASAN_OPTIONS is the reason for all the extra output and the build failure (the leak detector will cause a non-zero exit if it detects any leaks)..

@dipinhora
Copy link
Contributor

the issue is probably happening because the pool_memalign,address_sanitizer,undefined_behavior_sanitizer build is still defined in the original matrix that you removed the ifs from..

@SeanTAllen SeanTAllen merged commit cc62753 into main Jan 24, 2025
26 checks passed
@SeanTAllen SeanTAllen deleted the reorg-pr-sanitizers branch January 24, 2025 18:57
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants