Skip to content
This repository has been archived by the owner on Sep 14, 2024. It is now read-only.

[Feature Request] Custom filters #12

Open
Anacondo opened this issue Nov 28, 2023 · 6 comments
Open

[Feature Request] Custom filters #12

Anacondo opened this issue Nov 28, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Anacondo
Copy link

Please add the possibility to add new filters and/or edit the default ones. From what I can tell they're mostly hardcoded (re-sizing, tone mapping, audio processing, etc.) and I believe it would made sense to allow the user to modify them or at least define their own. Thanks a lot!

@porcino porcino self-assigned this Nov 28, 2023
@porcino porcino added the enhancement New feature or request label Nov 28, 2023
@porcino
Copy link
Owner

porcino commented Nov 30, 2023

Check the nightly build, you can now save with right click in the filter list, later I'm going to add an option to attach a description to each of them

@Anacondo
Copy link
Author

Thanks for the quick response! I'm getting a crash as soon as I click the "add filter" button, though:

System.NullReferenceException: Object reference not set to an instance of an object. at Av1ador.Form1.FilteraddDropDownButton_DropDownOpening(Object sender, EventArgs e) at System.Windows.Forms.ToolStripDropDownItem.OnDropDownShow(EventArgs e) at System.Windows.Forms.ToolStripDropDownItem.ShowDropDownInternal() at System.Windows.Forms.ToolStripDropDownItem.ShowDropDown(Boolean mousePush) at System.Windows.Forms.ToolStripDropDownButton.OnMouseDown(MouseEventArgs e) at System.Windows.Forms.ToolStripItem.HandleMouseDown(MouseEventArgs e) at System.Windows.Forms.ToolStrip.OnMouseDown(MouseEventArgs mea) at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ToolStrip.WndProc(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam) at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg) at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData) at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context) at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context) at Av1ador.Program.Main()

@porcino
Copy link
Owner

porcino commented Nov 30, 2023

@Anacondo sorry can you try again? just pushed a potential fix

@Anacondo
Copy link
Author

Filters menu seems to work now, but I get another crash as soon as I try to import a video:

System.NullReferenceException: Object reference not set to an instance of an object. at Av1ador.Form1.Get_res(String entry_res) at Av1ador.Form1.Mpv_load_first() at Av1ador.Form1.AddfilesButton_Click(Object sender, EventArgs e) at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e) at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e) at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e) at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea) at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ToolStrip.WndProc(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam) at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg) at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData) at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context) at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context) at Av1ador.Program.Main()

@porcino
Copy link
Owner

porcino commented Nov 30, 2023

I get another crash as soon as I try to import a video...

Fixed, that bug was old, it seems that I never encountered it because I always use drag and drop and that worked.

@Anacondo
Copy link
Author

Fixed, that bug was old, it seems that I never encountered it because I always use drag and drop and that worked.

Seems to work perfectly now, thanks a bunch! Any chance to be able to replace the default filters with these custom ones, or at least edit the defaults in some way?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants