From fe1072d879395f3d44b1aff4c10db406da0c5f36 Mon Sep 17 00:00:00 2001 From: Saksham Gupta Date: Tue, 5 Nov 2024 16:22:57 +0530 Subject: [PATCH] changed vault error message --- lib/runner/extensions/event.command.js | 2 +- test/integration/sanity/vaultSecrets.test.js | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/runner/extensions/event.command.js b/lib/runner/extensions/event.command.js index 5ccd36279..13963d3cb 100644 --- a/lib/runner/extensions/event.command.js +++ b/lib/runner/extensions/event.command.js @@ -411,7 +411,7 @@ module.exports = { const dispatch = (e, r) => { this.host.dispatch(EXECUTION_VAULT_BASE + executionId, id, e, r); }; if (!hasVaultAccess) { - return dispatch('Vault access denied'); + return dispatch('Vault access denied. Check your Vault settings.'); } if (!['get', 'set', 'unset'].includes(cmd)) { diff --git a/test/integration/sanity/vaultSecrets.test.js b/test/integration/sanity/vaultSecrets.test.js index 0bb949475..49de60864 100644 --- a/test/integration/sanity/vaultSecrets.test.js +++ b/test/integration/sanity/vaultSecrets.test.js @@ -1064,7 +1064,8 @@ describe('vaultSecrets', function () { 'exception.calledOnce': true }); - expect(testrun.exception.firstCall.args[1]).to.have.property('message', 'Vault access denied'); + // eslint-disable-next-line @stylistic/js/max-len + expect(testrun.exception.firstCall.args[1]).to.have.property('message', 'Vault access denied. Check your Vault settings.'); }); it('should not contain vault secrets', function () { @@ -1138,7 +1139,7 @@ describe('vaultSecrets', function () { it('should deny vault access for item2', function () { var prConsoleArgs = testrun.console.getCall(1).args.slice(2); - expect(prConsoleArgs).to.deep.equal(['Vault access denied']); + expect(prConsoleArgs).to.deep.equal(['ault access denied. Check your Vault settings.']); }); }); @@ -1188,7 +1189,7 @@ describe('vaultSecrets', function () { var consoleArgs = testrun.console.getCall(0).args.slice(2); expect(consoleArgs[0]).to.equal('Vault error:'); - expect(consoleArgs[1]).to.equal('Vault access denied'); + expect(consoleArgs[1]).to.equal('Vault access denied. Check your Vault settings.'); }); }); @@ -1238,7 +1239,7 @@ describe('vaultSecrets', function () { var consoleArgs = testrun.console.getCall(0).args.slice(2); expect(consoleArgs[0]).to.equal('Vault error:'); - expect(consoleArgs[1]).to.equal('Vault access denied'); + expect(consoleArgs[1]).to.equal('Vault access denied. Check your Vault settings.'); }); }); });