From 35e389ff57ae0de407976ab07bf45d1e62735c46 Mon Sep 17 00:00:00 2001 From: Dubyk Danylo <45672370+CTMBNara@users.noreply.github.com> Date: Fri, 13 Dec 2024 03:23:41 +0100 Subject: [PATCH] Rubicon: No longer copy certain FPD fields (#3919) Co-authored-by: ddubyk --- adapters/rubicon/rubicon.go | 18 ------------------ .../exemplary/25-26-transition-period.json | 4 ---- .../rubicontest/exemplary/app-imp-fpd.json | 8 -------- .../exemplary/bidonmultiformat.json | 12 ------------ .../rubicontest/exemplary/flexible-schema.json | 8 -------- .../rubicontest/exemplary/hardcode-secure.json | 4 ---- .../exemplary/non-bidonmultiformat.json | 6 ------ .../rubicontest/exemplary/simple-banner.json | 4 ---- .../rubicontest/exemplary/simple-native.json | 4 ---- .../rubicontest/exemplary/simple-video.json | 4 ---- .../rubicontest/exemplary/site-imp-fpd.json | 14 -------------- .../rubicontest/exemplary/user-fpd.json | 6 ------ .../supplemental/no-site-content-data.json | 4 ---- .../supplemental/no-site-content.json | 4 ---- 14 files changed, 100 deletions(-) diff --git a/adapters/rubicon/rubicon.go b/adapters/rubicon/rubicon.go index e5eb0fdc80c..a1a4083bfc1 100644 --- a/adapters/rubicon/rubicon.go +++ b/adapters/rubicon/rubicon.go @@ -646,21 +646,9 @@ func (a *RubiconAdapter) updateImpRpTarget(extImp rubiconExtImpBidder, extImpRub if err != nil { return nil, err } - if len(site.SectionCat) > 0 { - addStringArrayAttribute(site.SectionCat, target, "sectioncat") - } - if len(site.PageCat) > 0 { - addStringArrayAttribute(site.PageCat, target, "pagecat") - } if site.Page != "" { addStringAttribute(site.Page, target, "page") } - if site.Ref != "" { - addStringAttribute(site.Ref, target, "ref") - } - if site.Search != "" { - addStringAttribute(site.Search, target, "search") - } } else { appExtData, _, _, err := jsonparser.Get(app.Ext, "data") if isNotKeyPathError(err) { @@ -670,12 +658,6 @@ func (a *RubiconAdapter) updateImpRpTarget(extImp rubiconExtImpBidder, extImpRub if err != nil { return nil, err } - if len(app.SectionCat) > 0 { - addStringArrayAttribute(app.SectionCat, target, "sectioncat") - } - if len(app.PageCat) > 0 { - addStringArrayAttribute(app.PageCat, target, "pagecat") - } } if len(extImp.Context.Data) > 0 { diff --git a/adapters/rubicon/rubicontest/exemplary/25-26-transition-period.json b/adapters/rubicon/rubicontest/exemplary/25-26-transition-period.json index 0196c93049a..52cad5919eb 100644 --- a/adapters/rubicon/rubicontest/exemplary/25-26-transition-period.json +++ b/adapters/rubicon/rubicontest/exemplary/25-26-transition-period.json @@ -361,10 +361,6 @@ "rp": { "target": { "pbadslot": "pbadslot", - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/app-imp-fpd.json b/adapters/rubicon/rubicontest/exemplary/app-imp-fpd.json index 4906754af43..8982f95bff5 100644 --- a/adapters/rubicon/rubicontest/exemplary/app-imp-fpd.json +++ b/adapters/rubicon/rubicontest/exemplary/app-imp-fpd.json @@ -341,14 +341,6 @@ "attr5": [ "3" ], - "pagecat": [ - "val1", - "val2" - ], - "sectioncat": [ - "sectionCat1", - "sectionCat2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/bidonmultiformat.json b/adapters/rubicon/rubicontest/exemplary/bidonmultiformat.json index e39375ceb85..dc68d23f598 100644 --- a/adapters/rubicon/rubicontest/exemplary/bidonmultiformat.json +++ b/adapters/rubicon/rubicontest/exemplary/bidonmultiformat.json @@ -101,12 +101,6 @@ "page": [ "somePage" ], - "ref": [ - "someRef" - ], - "search": [ - "someSearch" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" @@ -210,12 +204,6 @@ "page": [ "somePage" ], - "ref": [ - "someRef" - ], - "search": [ - "someSearch" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/flexible-schema.json b/adapters/rubicon/rubicontest/exemplary/flexible-schema.json index 18af7fcfca6..b9bedd3aa47 100644 --- a/adapters/rubicon/rubicontest/exemplary/flexible-schema.json +++ b/adapters/rubicon/rubicontest/exemplary/flexible-schema.json @@ -341,14 +341,6 @@ "attr5": [ "3" ], - "pagecat": [ - "val1", - "val2" - ], - "sectioncat": [ - "sectionCat1", - "sectionCat2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/hardcode-secure.json b/adapters/rubicon/rubicontest/exemplary/hardcode-secure.json index 4089136b995..2040933b48e 100644 --- a/adapters/rubicon/rubicontest/exemplary/hardcode-secure.json +++ b/adapters/rubicon/rubicontest/exemplary/hardcode-secure.json @@ -319,10 +319,6 @@ "rp": { "target": { "pbadslot": "pbadslot", - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/non-bidonmultiformat.json b/adapters/rubicon/rubicontest/exemplary/non-bidonmultiformat.json index dae54aca730..534f8aae79d 100644 --- a/adapters/rubicon/rubicontest/exemplary/non-bidonmultiformat.json +++ b/adapters/rubicon/rubicontest/exemplary/non-bidonmultiformat.json @@ -100,12 +100,6 @@ "page": [ "somePage" ], - "ref": [ - "someRef" - ], - "search": [ - "someSearch" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/simple-banner.json b/adapters/rubicon/rubicontest/exemplary/simple-banner.json index 21ec12990da..86663034adb 100644 --- a/adapters/rubicon/rubicontest/exemplary/simple-banner.json +++ b/adapters/rubicon/rubicontest/exemplary/simple-banner.json @@ -320,10 +320,6 @@ "rp": { "target": { "pbadslot": "pbadslot", - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/simple-native.json b/adapters/rubicon/rubicontest/exemplary/simple-native.json index 98bfdb4f845..576faecbee4 100644 --- a/adapters/rubicon/rubicontest/exemplary/simple-native.json +++ b/adapters/rubicon/rubicontest/exemplary/simple-native.json @@ -304,10 +304,6 @@ "rp": { "target": { "pbadslot": "pbadslot", - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/simple-video.json b/adapters/rubicon/rubicontest/exemplary/simple-video.json index 56df274d845..ccdfab1699c 100644 --- a/adapters/rubicon/rubicontest/exemplary/simple-video.json +++ b/adapters/rubicon/rubicontest/exemplary/simple-video.json @@ -320,10 +320,6 @@ "rp": { "target": { "pbadslot": "pbadslot", - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/exemplary/site-imp-fpd.json b/adapters/rubicon/rubicontest/exemplary/site-imp-fpd.json index 114d9fde283..9a8468ce15a 100644 --- a/adapters/rubicon/rubicontest/exemplary/site-imp-fpd.json +++ b/adapters/rubicon/rubicontest/exemplary/site-imp-fpd.json @@ -458,20 +458,6 @@ "page": [ "somePage" ], - "ref": [ - "someRef" - ], - "search": [ - "someSearch" - ], - "pagecat": [ - "val1", - "val2" - ], - "sectioncat": [ - "sectionCat1", - "sectionCat2" - ], "dfp_ad_unit_code": "adSlotFromData", "pbs_login": "xuser", "pbs_url": "http://hosturl.com", diff --git a/adapters/rubicon/rubicontest/exemplary/user-fpd.json b/adapters/rubicon/rubicontest/exemplary/user-fpd.json index f62e5572075..a03234d48d4 100644 --- a/adapters/rubicon/rubicontest/exemplary/user-fpd.json +++ b/adapters/rubicon/rubicontest/exemplary/user-fpd.json @@ -268,12 +268,6 @@ "page": [ "somePage" ], - "ref": [ - "someRef" - ], - "search": [ - "someSearch" - ], "dfp_ad_unit_code": "someAdSlot", "pbs_login": "xuser", "pbs_url": "http://hosturl.com", diff --git a/adapters/rubicon/rubicontest/supplemental/no-site-content-data.json b/adapters/rubicon/rubicontest/supplemental/no-site-content-data.json index babce0a4aa6..b7d8f84287b 100644 --- a/adapters/rubicon/rubicontest/supplemental/no-site-content-data.json +++ b/adapters/rubicon/rubicontest/supplemental/no-site-content-data.json @@ -230,10 +230,6 @@ "ext": { "rp": { "target": { - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": "" diff --git a/adapters/rubicon/rubicontest/supplemental/no-site-content.json b/adapters/rubicon/rubicontest/supplemental/no-site-content.json index 20f8a7144fe..bcdd9acb9a2 100644 --- a/adapters/rubicon/rubicontest/supplemental/no-site-content.json +++ b/adapters/rubicon/rubicontest/supplemental/no-site-content.json @@ -226,10 +226,6 @@ "ext": { "rp": { "target": { - "pagecat": [ - "val1", - "val2" - ], "pbs_login": "xuser", "pbs_url": "http://hosturl.com", "pbs_version": ""