Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftover API changes which were missed in the v3.0.0 release #57

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Leftover API changes which were missed in the v3.0.0 release #57

merged 6 commits into from
Feb 23, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Feb 14, 2024 •
edited
Loading

The following updates were not done in the v3.0.0 release and are not done:

  • The old API function getMeshVerticesAndIDs needs to be updated to getMeshVertexIDsAndCoorindates.
  • Some other minor updates are also included in the same PR.

@IshaanDesai IshaanDesai self-assigned this Feb 14, 2024
@IshaanDesai IshaanDesai added the bug Something isn't working label Feb 14, 2024
@IshaanDesai IshaanDesai linked an issue Feb 14, 2024 that may be closed by this pull request
Correspondance between PreCICE.jl and source code #53
Closed
@IshaanDesai IshaanDesai requested a review from davidscn February 14, 2024 20:36
davidscn
davidscn reviewed Feb 15, 2024
View reviewed changes
src/PreCICE.jl Outdated Show resolved Hide resolved
src/PreCICE.jl Show resolved Hide resolved
src/PreCICE.jl Show resolved Hide resolved
@marinlauber
Copy link

@IshaanDesai @davidscn I quickly tested the new function getMeshVertexIDsAndCoordinates, and the mesh vertices returned by that function is the transpose of the one written by the other participant. Is that the desired behavior?

I have attached the solverdummy.jl and the config file to replicate the behavior
preCICE-debug.zip

Getting rid of the permutedims at the function return line solves it.

@IshaanDesai IshaanDesai changed the title Use correct API function name getMeshVertexIDsAndCoordinates Leftover API changes which were missed in the v3.0.0 release Feb 22, 2024
marinlauber
marinlauber approved these changes Feb 23, 2024
View reviewed changes
Copy link

@marinlauber marinlauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for that @IshaanDesai

@IshaanDesai IshaanDesai merged commit 0a25a15 into develop Feb 23, 2024
13 checks passed
@IshaanDesai IshaanDesai deleted the api-repair branch February 23, 2024 09:20
@IshaanDesai IshaanDesai mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinlauber marinlauber marinlauber approved these changes

@davidscn davidscn davidscn approved these changes

Assignees

@IshaanDesai IshaanDesai

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correspondance between PreCICE.jl and source code
3 participants
@IshaanDesai @marinlauber @davidscn