Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the @zk-kit/artifacts package and set the new CDN URL as the default one #94

Closed
Tracked by #89
sripwoud opened this issue Jun 20, 2024 · 3 comments · Fixed by #97
Closed
Tracked by #89

Update the @zk-kit/artifacts package and set the new CDN URL as the default one #94

sripwoud opened this issue Jun 20, 2024 · 3 comments · Fixed by #97
Assignees
@sripwoud
Labels
enhancement New feature or request

Comments

@sripwoud
Copy link
Member

No description provided.

@sripwoud sripwoud mentioned this issue Jun 20, 2024
Closed
3 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in SNARK Artifacts Jun 20, 2024
@cedoor cedoor moved this from 📋 Backlog to ♻️ Grooming in SNARK Artifacts Jun 20, 2024
@cedoor cedoor added the enhancement New feature or request label Jun 20, 2024
@sripwoud sripwoud self-assigned this Jun 20, 2024
@sripwoud
Copy link
Member Author

@cedoor should we move on with implementing a client side solution (that we would remove when the backend solution is implemented #95)?
Or should we wait for #95 to be solved first?

@cedoor
Copy link
Member

cedoor commented Jun 20, 2024

Looks like the "latest" URLs are working. Does it make sense to move on with them?

@sripwoud
Copy link
Member Author

sripwoud commented Jun 21, 2024 •
edited
Loading

Based on my benchmark, using snark-artifacts.pse.dev as default downloading url would degrade performance is the fastest! See #96
let's wait for Nick's feedback to see if we can improve that.

So let's move on defaulting to that url

@sripwoud sripwoud moved this from ♻️ Grooming to 🏗 In Progress in SNARK Artifacts Jun 21, 2024
@sripwoud sripwoud mentioned this issue Jun 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✔️ Done in SNARK Artifacts Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sripwoud sripwoud

Labels
enhancement New feature or request
Projects
SNARK Artifacts
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(artifacts): download artifacts from pse CDN privacy-scaling-explorations/snark-artifacts
2 participants
@cedoor @sripwoud