Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Reset the python dependencies cache weekly #1146

Closed
thomass-dev opened this issue Jan 17, 2025 · 5 comments · Fixed by #1238
Closed

ci: Reset the python dependencies cache weekly #1146

thomass-dev opened this issue Jan 17, 2025 · 5 comments · Fixed by #1238
Assignees
@thomass-dev
Labels
chore Internal enhancement work to be done

Comments

@thomass-dev
Copy link
Collaborator

thomass-dev commented Jan 17, 2025 •
edited
Loading

Following #1141, we saw that we should upgrade dependencies regularly.
One solution can be to add a bot that purge the cache weekly.
@thomass-dev thomass-dev self-assigned this Jan 20, 2025
@MarieS-WiMLDS MarieS-WiMLDS added the chore Internal enhancement work to be done label Jan 23, 2025
@auguste-probabl
Copy link
Contributor

isn't it enough to purge the cache when the lockfile changes (see #1238)?

@thomass-dev
Copy link
Collaborator Author

thomass-dev commented Jan 29, 2025 •
edited
Loading

Yes it will be solved that way in #1238 .

@rouk1
Copy link
Contributor

rouk1 commented Jan 30, 2025

Is caching dependencies a real performance improvement ?
Because if not having no cache could be simpler : )

@thomass-dev
Copy link
Collaborator Author

thomass-dev commented Jan 30, 2025 •
edited
Loading

Yes it is, the gain is about 1min on each job in the backend.yml workflow 😄 (so a gain of ~10 minutes).

@rouk1
Copy link
Contributor

rouk1 commented Jan 30, 2025

Ok that is significant : )

@thomass-dev thomass-dev mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomass-dev thomass-dev

Labels
chore Internal enhancement work to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Use lockfiles to control cached venv probabl-ai/skore
4 participants
@rouk1 @thomass-dev @MarieS-WiMLDS @auguste-probabl