Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper use of scrollLeft and scrollRight in resetTriggers in non-default writing modes #9

Open
fred-wang opened this issue Jan 10, 2020 · 0 comments
Open

Improper use of scrollLeft and scrollRight in resetTriggers in non-default writing modes #9

fred-wang opened this issue Jan 10, 2020 · 0 comments

Comments

@fred-wang
Copy link

This code was copied from javascript-detect-element-resize, see:

sdecima/javascript-detect-element-resize#61
fred-wang added a commit to fred-wang/ResizeSensor that referenced this issue Feb 15, 2020
@fred-wang
Make resize triggers use default CSS writing mode
9384428 
The Chromium community is moving to scroll position values indicated in
the CSSOM specification [1]. In order to launch the feature and analyze
potential broken URLs, they count pages setting the scroll position of
a scroller in non-default writing mode to a positive value. Websites
using javascript-detect-element-resize in RTL or vertical mode appear
in the top results and cause a lot of false positives [2]. In order to
avoid that, ensure that the resize triggers use the default writing
mode (direction: ltr and writing-mode: horizontal-tb).

[1] https://www.chromestatus.com/feature/5759578031521792
[2] procurios#9
@fred-wang fred-wang mentioned this issue Feb 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fred-wang