From 37f1285c6e7de828d52bcd9c234fd58ab0540424 Mon Sep 17 00:00:00 2001
From: Marco Gomiero <marco.gomiero.93@gmail.com>
Date: Sun, 21 Jul 2024 18:51:24 +0200
Subject: [PATCH] Improve error logging

---
 .../Dropbox/Data/DropboxDataSourceIos.swift   | 21 ++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/iosApp/Source/Accounts/Dropbox/Data/DropboxDataSourceIos.swift b/iosApp/Source/Accounts/Dropbox/Data/DropboxDataSourceIos.swift
index 8ac67f4b..13467898 100644
--- a/iosApp/Source/Accounts/Dropbox/Data/DropboxDataSourceIos.swift
+++ b/iosApp/Source/Accounts/Dropbox/Data/DropboxDataSourceIos.swift
@@ -29,7 +29,7 @@ class DropboxDataSourceIos: DropboxDataSource {
             switch result {
             case .success(let requestBox):
                 return requestBox
-            case .failure(let error):
+            case .failure:
                 return nil
             }
         }
@@ -103,10 +103,21 @@ class DropboxDataSourceIos: DropboxDataSource {
                         completionHandler(downloadResult, nil)
 
                     } else if let error = error {
-                        print(error)
                         KotlinDependencies.shared.getLogger(tag: "DropboxDataSourceIos").e(
-                            messageString: error.localizedDescription
+                            messageString: error.description
                         )
+
+                        switch error as CallError {
+                        case .routeError(let boxed, _, _, _):
+                            let err = boxed.unboxed as Files.DownloadError
+                            KotlinDependencies.shared.getLogger(tag: "DropboxDataSourceIos").e(
+                                messageString: "Boxed error: \(err.description)"
+                            )
+
+                        default:
+                            break
+                        }
+
                         completionHandler(nil, DropboxErrors.downloadError(reason: error.description))
                     }
                 }
@@ -142,7 +153,7 @@ class DropboxDataSourceIos: DropboxDataSource {
                     )
 
                     switch error as CallError {
-                    case .routeError(let boxed, let userMessage, let errorSummary, let requestId):
+                    case .routeError(let boxed, _, _, _):
                         let err = boxed.unboxed as Files.UploadError
                         KotlinDependencies.shared.getLogger(tag: "DropboxDataSourceIos").e(
                             messageString: "Boxed error: \(err.description)"
@@ -203,6 +214,6 @@ class DropboxDataSourceIos: DropboxDataSource {
     }
 
     private func createClient() -> DropboxClient? {
-        DropboxClientsManager.authorizedClient
+        DropboxClientsManager.authorizedClient ?? DropboxClientsManager.authorizedBackgroundClient
     }
 }