Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wikidata Guesser Needs Refactor #199

Open
1 task
kkdavis14 opened this issue Jan 6, 2025 · 0 comments · May be fixed by #205
Open
1 task

[Bug]: Wikidata Guesser Needs Refactor #199

kkdavis14 opened this issue Jan 6, 2025 · 0 comments · May be fixed by #205
Assignees
Labels
bug The code does not behave as expected / designed

Comments

@kkdavis14
Copy link
Contributor

kkdavis14 commented Jan 6, 2025

Priority Level

Low

What happened?

Some of the properties in use to guess a Class aren't effective:

p571 (inception) as a metric for assigning the class of HumanMadeObject is a problem as lots of things that aren’t objects have p571, e.g.:
https://www.wikidata.org/wiki/Q43173
https://lux.collections.yale.edu/view/object/2aba9c00-814a-4bbb-b30d-db267fe330e9

P580, P582 (start and end time) and P571 can be used interchangeably by Wikipedians. Generally the prior are for events, but P571 is used often one Events and Objects. I think it's safe to use the prior as a metric for Events, especially because they have so few other valid properties, but not safe to use the latter as a metric for Objects (or at all).

Wikidata mapper should account for Activities in Guesser.

Relevant log output

No response

Additional Tasks

  • Refactor the guess_type function in Wikidata Mapper to better suit current LUX requirements
@kkdavis14 kkdavis14 added the bug The code does not behave as expected / designed label Jan 6, 2025
@kkdavis14 kkdavis14 self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not behave as expected / designed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant