From 64f30019b0b18c8ad103333e4b1134a9049d7a48 Mon Sep 17 00:00:00 2001
From: Cory Lown <corylown@stanford.edu>
Date: Tue, 19 Nov 2024 10:40:01 -0500
Subject: [PATCH] Fixup rubocop config so CI will run

---
 .rubocop.yml                          |  4 ----
 .rubocop_todo.yml                     | 33 +++++++++++++++++----------
 spec/features/collection_page_spec.rb |  2 +-
 3 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 9782c2e02..c765970b8 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -33,10 +33,6 @@ Metrics/BlockLength:
     - 'spec/**/*'
     - 'tasks/**/*'
 
-Naming/PredicateName:
-  ForbiddenPrefixes:
-    - _is
-
 Layout/LineLength:
   Max: 160
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index acffb77dd..a8c219553 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-02-27 17:35:23 UTC using RuboCop version 1.46.0.
+# on 2024-11-19 15:29:44 UTC using RuboCop version 1.68.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 10
+# Offense count: 13
 # Configuration parameters: EnforcedStyle, AllowedGems, Include.
 # SupportedStyles: Gemfile, gems.rb, gemspec
 # Include: **/*.gemspec, **/Gemfile, **/gems.rb
@@ -19,7 +19,7 @@ Gemspec/DevelopmentDependencies:
 Metrics/AbcSize:
   Max: 19
 
-# Offense count: 1
+# Offense count: 2
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 8
@@ -34,7 +34,17 @@ Metrics/MethodLength:
 Metrics/PerceivedComplexity:
   Max: 9
 
-# Offense count: 60
+# Offense count: 1
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'app/components/arclight/collection_sidebar_component.rb'
+
+# Offense count: 66
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -42,36 +52,35 @@ RSpec/ContextWording:
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle.
+# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
   Exclude:
     - 'spec/presenters/arclight/show_presenter_spec.rb'
 
-# Offense count: 60
+# Offense count: 63
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 49
 
-# Offense count: 112
+# Offense count: 121
 RSpec/MultipleExpectations:
-  Max: 22
+  Max: 24
 
-# Offense count: 37
+# Offense count: 51
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 10
 
-# Offense count: 22
+# Offense count: 26
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 5
 
-# Offense count: 2
+# Offense count: 1
 RSpec/PendingWithoutReason:
   Exclude:
     - 'spec/features/document_tools_spec.rb'
-    - 'spec/features/google_form_request_spec.rb'
 
 # Offense count: 5
 # This cop supports unsafe autocorrection (--autocorrect-all).
diff --git a/spec/features/collection_page_spec.rb b/spec/features/collection_page_spec.rb
index d9898445a..745fa6b04 100644
--- a/spec/features/collection_page_spec.rb
+++ b/spec/features/collection_page_spec.rb
@@ -73,7 +73,7 @@
       end
     end
 
-    it 'background has configured metadata' do # rubocop:disable RSpec/MultipleExpectations
+    it 'background has configured metadata' do
       within '#background' do
         expect(page).to have_css('dt', text: 'Scope and content')
         expect(page).to have_css('dd', text: /^Correspondence, documents, records, photos/)