Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-kube-stack] Helm upgrade always creates a new revision, even if nothing changed #5236

Open
cowwoc opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@cowwoc
Copy link

cowwoc commented Jan 24, 2025

Describe the bug a clear and concise description of what the bug is.

helm upgrade is not supposed to do anything if the chart and input values do not change, but when I run helm upgrade on this chart it always increases the revision number and creates new resources. Other charts seem to work fine.

What's your helm version?

version.BuildInfo{Version:"v3.17.0", GitCommit:"301108edc7ac2a8ba79e4ebf5701b0b6ce6a31e4", GitTreeState:"clean", GoVersion:"go1.23.4"}

What's your kubectl version?

Client Version: v1.30.5 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.31.4+k3s1

Which chart?

kube-prometheus-stack

What's the chart version?

68.3.0

What happened?

If I run helm upgrade prometheus prometheus/kube-prometheus-stack --namespace database-monitor --create-namespace --install

multiple times, a new revision of the chart is installed each time and a new sh.helm.release.v1.prometheus.* secret is installed (e.g. sh.helm.release.v1.prometheus.v1, sh.helm.release.v1.prometheus.v2 and so on).

What you expected to happen?

If the chart and input values did not change, the chart revision should not increase and no new secrets should be installed.

How to reproduce it?

Run helm upgrade prometheus prometheus/kube-prometheus-stack --namespace database-monitor --create-namespace --install multiple times

Enter the changed values of values.yaml?

NONE

Enter the command that you execute and failing/misfunctioning.

helm upgrade prometheus prometheus/kube-prometheus-stack --namespace database-monitor --create-namespace --install

Anything else we need to know?

Here is the output of running the aforementioned command with --debug added: out.log

It looks like the prometheus-kube-prometheus-admission service account is always being recreated needlessly.

@cowwoc cowwoc added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant