Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core 3.70 compat] Django storages config deprecation #1216

Open
2 of 3 tasks
pedro-psb opened this issue Jan 10, 2025 · 2 comments
Open
2 of 3 tasks

[core 3.70 compat] Django storages config deprecation #1216

pedro-psb opened this issue Jan 10, 2025 · 2 comments

Comments

@pedro-psb
Copy link
Member

Action for django's storages deprecation:

  1. Pre or on core-3.70 compat declaration:
    • Replace legacy with new (not required)
    • Settings on signal-handler (not required)
  2. On core 3.70 compat declaration: (closes this)
    • Use new setting in one CI scenario

See for context:
https://discourse.pulpproject.org/t/action-required-plugins-should-use-djangos-new-storage-config-for-3-70/1866

@hstct
Copy link
Contributor

hstct commented Jan 16, 2025

We don't have any occurrences of using DEFAULT_FILE_STORAGE in pulp deb. Is it sufficient to just do this step then? -> Edit the .ci/ansible/settings.py.j2 file

Or do we need to move settings to class level as well?

@pedro-psb
Copy link
Member Author

Yes, only 2 is required here.
This week we noticed the file settings.py.j2 is managed by pluging_template, so there is a minor update on this step.
You should:

  1. Add test_storages_compat_layer: true to template_config.yaml
  2. run plugin-template

Example in pulpcore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants