Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov is inaccurate for some bridged providers #1264

Open
blampe opened this issue Jan 4, 2025 · 0 comments
Open

Codecov is inaccurate for some bridged providers #1264

blampe opened this issue Jan 4, 2025 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@blampe
Copy link
Contributor

blampe commented Jan 4, 2025

https://pulumi.slack.com/archives/C02FXTZEZ6W/p1734114857515509

We recently starting reporting coverage from most/all of our bridged providers, but it doesn't appear to match what we would expect to see.

I suspect this is due to -coverpkg not working as expected -- this is trying to grab coverage for our provider's module as well as the upstream tf module.

-coverpkg="./...,github.com/hashicorp/terraform-provider-..." \

I'd recommend generating some coverage locally to confirm it at least captures some expected provider modules. If that's not working as expected I would try just -coverpkg=./.... If coverpkg isn't the issue then there's something wrong with how we're reporting to codecov.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jan 4, 2025
@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec and removed needs-triage Needs attention from the triage team labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants