Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform-provider-aws to v5.32.1 #3256

Closed
wants to merge 9 commits into from
Closed

Upgrade terraform-provider-aws to v5.32.1 #3256

wants to merge 9 commits into from

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 12, 2024

This PR was generated via $ upgrade-provider pulumi/pulumi-aws.

@iwahbe iwahbe added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jan 12, 2024
@iwahbe iwahbe self-assigned this Jan 12, 2024
@iwahbe iwahbe requested a review from a team January 12, 2024 19:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 6 breaking changes:

Resources

  • 🟢 "aws:cloud9/environmentEC2:EnvironmentEC2": required inputs: "imageId" input has changed to Required
  • 🟢 "aws:fsx/ontapFileSystem:OntapFileSystem": required: "throughputCapacity" property is no longer Required

Types

  • 🟢 "aws:efs/getFileSystemLifecyclePolicy:getFileSystemLifecyclePolicy": required: "transitionToArchive" property has changed to Required
  • 🟢 "aws:glue/getCatalogTableTargetTable:getCatalogTableTargetTable": required: "region" property has changed to Required
  • 🟡 "aws:iot/CaCertificateRegistrationConfig:CaCertificateRegistrationConfig": properties: "roleArn" type changed from "boolean" to "string"
  • 🟢 "aws:networkfirewall/getFirewallPolicyFirewallPolicy:getFirewallPolicyFirewallPolicy": required: "tlsInspectionConfigurationArn" property has changed to Required

New resources:

  • amp/scraper.Scraper
  • ebs/fastSnapshotRestore.FastSnapshotRestore
  • elasticache/serverlessCache.ServerlessCache
  • imagebuilder/workflow.Workflow
  • kinesis/resourcePolicy.ResourcePolicy
  • securitylake/awsLogSource.AwsLogSource
  • ssoadmin/applicationAccessScope.ApplicationAccessScope
  • verifiedpermissions/policyStore.PolicyStore
  • verifiedpermissions/policyTemplate.PolicyTemplate
  • verifiedpermissions/schema.Schema

New functions:

  • mq/getBrokerEngineTypes.getBrokerEngineTypes
  • msk/getBootstrapBrokers.getBootstrapBrokers
  • verifiedpermissions/getPolicyStore.getPolicyStore

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe enabled auto-merge (squash) January 12, 2024 20:27
@blampe
Copy link
Contributor

blampe commented Jan 12, 2024

@iwahbe

panic: no AWS SDK v1 API client factory: s3

hmm

@iwahbe
Copy link
Member Author

iwahbe commented Jan 12, 2024

@iwahbe

panic: no AWS SDK v1 API client factory: s3

hmm

I see it. That is used in an old part of our legacy s3 bucket implementation, and I needed to extend the patch to keep it compiling. It sounds like I need to take another look there.

@t0yv0
Copy link
Member

t0yv0 commented Jan 16, 2024

Intending to finish this up or handing it over? Thanks. That's the only Tier 1 provider upgrade requested at the moment.

@iwahbe
Copy link
Member Author

iwahbe commented Jan 16, 2024

Intending to finish this up or handing it over? Thanks. That's the only Tier 1 provider upgrade requested at the moment.

We just discussed and I will be handing over. Documenting here for continuity.

@iwahbe iwahbe assigned t0yv0 and unassigned iwahbe Jan 16, 2024
t0yv0
t0yv0 reviewed Jan 23, 2024
View reviewed changes
provider/doc_edits.go
@@ -186,6 +186,13 @@ func (r replacementFile) checkForTODOs(path string, content []byte) {
start, end = findLine(content, m[0])
line := string(content[start:end])

// Do not add duplicate replacements to requirements.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. I didn't dissect his PR into commits and missed this so ended up reimplementing.

@t0yv0 t0yv0 closed this Jan 23, 2024
auto-merge was automatically disabled January 23, 2024 01:38

Pull request was closed

@t0yv0 t0yv0 deleted the upgrade-terraform-provider-aws-to-v5.32.1 branch January 23, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 left review comments

@blampe blampe blampe approved these changes

Assignees

@t0yv0 t0yv0

Labels
needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.32.1 Upgrade terraform-provider-aws to v5.32.0
3 participants
@iwahbe @blampe @t0yv0