Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AcmCertificateValidation examples shortcode with Pulumi Code Chooser #3476

Closed
guineveresaenger opened this issue Feb 23, 2024 · 1 comment · Fixed by #3656
Closed

Replace AcmCertificateValidation examples shortcode with Pulumi Code Chooser #3476

guineveresaenger opened this issue Feb 23, 2024 · 1 comment · Fixed by #3656
Assignees
@guineveresaenger
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@guineveresaenger
Copy link
Contributor

https://github.com/pulumi/pulumi-aws/blob/master/docs/resource/aws_acm_certificate_validation.examples.md is a docs overwrite that no longer will need the {{% example %}} shortcode after pulumi/pulumi-terraform-bridge#1689 applies.

Instead, we should:

  • verify we still need this extra doc
  • if we do, replace {% example %}} with <--Begin PulumiCodeChooser --> and {{% /example %}} with ``<--End PulumiCodeChooser -->`
@guineveresaenger guineveresaenger added the kind/engineering Work that is not visible to an external user label Feb 23, 2024
@guineveresaenger guineveresaenger self-assigned this Mar 18, 2024
@guineveresaenger
Copy link
Contributor Author

update: this doc is very stale at this point, and upstream looks correct. We should be able to remove this extra doc.

@guineveresaenger guineveresaenger mentioned this issue Mar 18, 2024
Merged
guineveresaenger added a commit that referenced this issue Mar 20, 2024
@guineveresaenger
Remove stale doc for acm.CertificateValidation (#3656)
6b5fbc5 
Fixes #3476.

- Remove manually-maintained doc for aws.acm.CertificateValidation and
use upstream instead
- update sdks
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stale doc for acm.CertificateValidation pulumi/pulumi-aws
2 participants
@guineveresaenger @pulumi-bot