Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws lambda runtime constants #4424

Closed
LazaroOnline opened this issue Sep 3, 2024 · 3 comments
Closed

Update aws lambda runtime constants #4424

LazaroOnline opened this issue Sep 3, 2024 · 3 comments
Assignees

Comments

@LazaroOnline
Copy link

Update the aws.lambda runtime constants to add the new versions available.
In this repo's file:
https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/lambda/runtimes.ts

In particular related to NodeJs I can only see up to "nodejs12.x", and at the moment of this writing there is up until "nodejs20.x", so it is missing:
"nodejs14.x"
"nodejs16.x"
"nodejs18.x"
"nodejs20.x"

For the other languages I imagine it is also outdated.

The "@deprecated" comment should also be added to the relevant versions.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 3, 2024
@LazaroOnline
Copy link
Author

I was using those constants from this code from import * as aws from "@pulumi/aws";
aws.lambda.NodeJS12dXRuntime

But I just discovered there is another file that is up to date here:
aws.lambda.Runtime.NodeJS20dX

Now the question is what is the difference and if the old one can be removed.

@t0yv0
Copy link
Member

t0yv0 commented Sep 3, 2024

Glad you found the updated list. The SDK retains the older enum values for backwards-compat, as the doc comment says:

/** The NodeJS12dXRuntime constant is deprecated, use Runtime.NodeJS12dX instead. */
export let NodeJS12dXRuntime:    Runtime = "nodejs12.x";

@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Sep 3, 2024
@t0yv0
Copy link
Member

t0yv0 commented Sep 3, 2024

Looks like these were marked with @deprecated but this was removed in #1194

I will follow up here with the team, thanks for calling this to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants