Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs AWS ECR lifecycle policy doesn't support tagPatternList parameter #5119

Open
joneteus opened this issue Jan 21, 2025 · 1 comment
Open
Labels
area/overlays Issues pertaining to language-specific overlay code such as CallbackFunction good-first-issue Start here if you'd like to start contributing to Pulumi kind/bug Some behavior is incorrect or out of spec

Comments

@joneteus
Copy link

Describe what happened

Missing feature.

Nodejs SDK type Selection for ECR lifecycle policies is missing tagPatternList option. Tag pattern list allows to use wildcards in policy rules.

https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-elastic-container-registry-wildcards-lifecycle-policies/

https://docs.aws.amazon.com/AmazonECR/latest/userguide/lifecycle_policy_parameters.html#lp_tag_pattern_list

https://github.com/pulumi/pulumi-aws/blob/2b29733b78a352d7b6cccf00b83f22fb434347fe/sdk/nodejs/ecr/lifecyclePolicyDocument.ts#L53C18-L53C27

Looks like it is implemented in Pulumi AWS dotnet and Java SDKs but not Nodejs.

Sample program

Missing feature. Nothing to demonstrate.

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

Missing feature. Nothing to demonstrate.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@joneteus joneteus added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jan 21, 2025
@corymhall corymhall added area/overlays Issues pertaining to language-specific overlay code such as CallbackFunction good-first-issue Start here if you'd like to start contributing to Pulumi and removed needs-triage Needs attention from the triage team labels Jan 21, 2025
@corymhall
Copy link
Contributor

@joneteus thanks for raising this with us. It looks like the LIfecyclePolicyDocument type is a nodejs overlay type which means that it is manually maintained. If you look at the input type for other languages you will notice that the type is just string https://www.pulumi.com/registry/packages/aws/api-docs/ecr/lifecyclepolicy/#inputs

Alternatively you can use the getLifecyclePolicyDocument function which does have the tagPatternList parameter.

We would happily take a contribution to add the tagPatternList parameter to the nodejs overlay type here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/overlays Issues pertaining to language-specific overlay code such as CallbackFunction good-first-issue Start here if you'd like to start contributing to Pulumi kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants