Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream 5.84.0 #5120

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Upstream 5.84.0 #5120

merged 6 commits into from
Jan 21, 2025

Conversation

corymhall
Copy link
Contributor

closes #5113

@corymhall corymhall requested review from t0yv0 and flostadler January 21, 2025 16:22
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it look from the changelog if any awaiting/upstream issues are fixed by upstream? Thanks!

Copy link

github-actions bot commented Jan 21, 2025

Does the PR have any schema changes?

Found 4 breaking changes:

Resources

  • "aws:kms/customKeyStore:CustomKeyStore": required:
    • 🟢 "cloudHsmClusterId" property is no longer Required
    • 🟢 "keyStorePassword" property is no longer Required
    • 🟢 "trustAnchorCertificate" property is no longer Required

Types

  • 🟢 "aws:ec2/getInstanceTypeInferenceAccelerator:getInstanceTypeInferenceAccelerator": required: "memorySize" property has changed to Required

New resources:

  • mediapackagev2/channelGroup.ChannelGroup

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes missing coverage. Please review.

Project coverage is 24.47%. Comparing base (357de3a) to head (a8e8025).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
sdk/go/aws/globalaccelerator/accelerator.go 36.36% 7 Missing ⚠️
sdk/go/aws/globalaccelerator/listener.go 30.00% 7 Missing ⚠️
sdk/go/aws/elasticache/user.go 42.85% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5120   +/-   ##
=======================================
  Coverage   24.46%   24.47%           
=======================================
  Files         361      361           
  Lines      144037   144065   +28     
=======================================
+ Hits        35243    35260   +17     
- Misses     108696   108707   +11     
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@corymhall corymhall merged commit 55733ab into master Jan 21, 2025
26 checks passed
@corymhall corymhall deleted the corymhall/upstream-584 branch January 21, 2025 20:09
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.67.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.84.0
3 participants