Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pulumi-docker v4 #1077

Closed
thomas11 opened this issue Sep 5, 2023 · 3 comments
Closed

Upgrade to pulumi-docker v4 #1077

thomas11 opened this issue Sep 5, 2023 · 3 comments
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@thomas11
Copy link
Contributor

thomas11 commented Sep 5, 2023

This was attempted before in #1044 but had to be reverted in #1054 after conversation with @pierskarsenbarg and @lukehoban.

We need to fix the imageName vs repoDigest issue and get to the bottom of the question about env in the first PR.

This will likely be a breaking update, i.e., a new major version, but ideally we can combine it with #1068 in one new version.

@thomas11 thomas11 added the kind/enhancement Improvements or new features label Sep 5, 2023
@AaronFriel
Copy link
Contributor

I don't believe "env" is required anymore, but it will be a breaking change to remove it.

Docker builds cannot use env vars directly, a user must pass a build arg which is consumed by the Dockerfile "ARG" statement, that can then be declared as the default value of an env var in the build.

The env input however could control DOCKER_HOST, DOCKER_BUILDKIT, etc. These change Docker engine behavior, and they now respect provider or resource inputs.

@mjeffryes mjeffryes added the resolution/fixed This issue was fixed label Jan 3, 2024
@mjeffryes
Copy link
Member

the latest pinned version of docker is 4.5.0

@pulumi-bot pulumi-bot reopened this Jan 3, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have an assignee

Please fix these problems and try again.

@mjeffryes mjeffryes self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants