Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure deduplicated dependencies #1482

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 15, 2025

This is an important check to include to fail early. If Renovate updates dependencies in a way that causes several copies of @pulumi/pulumi SDK to be included then the provider fails at runtime with an obscure error about invokes, as in #1479 - this will fail the build early instead.

Copy link

github-actions bot commented Jan 15, 2025

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4aeca78) to head (004d02d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1482   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          10      10           
  Lines        2345    2345           
======================================
  Misses       2345    2345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When Renovate bot updates dependencies for the provider, we want to make
sure that the new set of dependencies does not result in any duplication
aka several versions of `@pulumi/pulumi` being included.
@t0yv0 t0yv0 enabled auto-merge (squash) January 15, 2025 14:23
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 merged commit 9450904 into master Jan 15, 2025
25 checks passed
@t0yv0 t0yv0 deleted the t0yv0/ensure-deduplicated-deps branch January 15, 2025 15:11
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants