Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove custom Make targets #1485

Merged
merged 5 commits into from
Jan 16, 2025
Merged

chore: remove custom Make targets #1485

merged 5 commits into from
Jan 16, 2025

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 15, 2025

Applies pulumi/ci-mgmt#1292 to this repository to remove the need for custom Make targets.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 force-pushed the t0yv0/remove-make-extenders branch from 3b3c4aa to b3e54e6 Compare January 16, 2025 18:38
@t0yv0 t0yv0 changed the title WIP: remove make extenders chore: remove custom Make targets Jan 16, 2025
@t0yv0 t0yv0 marked this pull request as ready for review January 16, 2025 18:39
@@ -0,0 +1,53 @@
#!/usr/bin/env bash

set -euo pipefail
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to wait with this one until we have reliable x-platform verification of the binaries.

@t0yv0
Copy link
Member Author

t0yv0 commented Jan 16, 2025

The changes in ci-mgmt to ensure release verification on mac are now included.

@t0yv0 t0yv0 requested a review from a team January 16, 2025 23:00
@t0yv0 t0yv0 enabled auto-merge (squash) January 16, 2025 23:23
@t0yv0 t0yv0 merged commit ece099c into master Jan 16, 2025
22 checks passed
@t0yv0 t0yv0 deleted the t0yv0/remove-make-extenders branch January 16, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants