Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0010-Remove-pattern-string-from-compute-forwarding-rules.patch #2326

Closed
guineveresaenger opened this issue Aug 20, 2024 · 2 comments
Closed
Assignees
Labels
area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone

Comments

@guineveresaenger
Copy link
Contributor

Per #2324, we should be able to remove this patch.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 20, 2024
@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user area/patch An issue describing an existing patch on upstream and the criteria to close it. and removed needs-triage Needs attention from the triage team labels Aug 21, 2024
@cleverguy25
Copy link

Added to epic #2290

@cleverguy25 cleverguy25 mentioned this issue Aug 21, 2024
5 tasks
@guineveresaenger guineveresaenger self-assigned this Aug 27, 2024
@mjeffryes mjeffryes added this to the 0.110 milestone Sep 12, 2024
guineveresaenger added a commit that referenced this issue Sep 13, 2024
Upgrades upstream provider to v6.0.1.

Resolves #2348.
Resolves #2357
- Adds a patch for renaming new default label to
`goog-pului-provisioned`
    - Renames config field to `addPulumiAttributionLabel`
    - Adjusts labels tests to expect new label
- Adjusts bucket label patch to avoid writing this label to the Bucket
resource itself.

Introduces additional breaking change via cloudrunv2.Service `ports`
field, which is now a MaxItemsOne upstream, which turns it into an
object on our end, rather than an array entry. Look for a state
transformer on the resource for upgrades.

Removes patches:
- [~Remove
0002-Add-nil-checks-for-sql-database-instance-flattening.patch~](#2319)
- [Remove
0010-Remove-pattern-string-from-compute-forwarding-rules.patch](#2326)
- [Remove
Add-flattening-of-self-managed-certificates.patch](#1188)
@guineveresaenger guineveresaenger added the resolution/fixed This issue was fixed label Sep 13, 2024
@guineveresaenger
Copy link
Contributor Author

Closed via #2355.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

5 participants