Fix PULUMI_GCP_DISABLE_GLOBAL_PROJECT_WARNING/gcp:disableGlobalProjectWarning

[iwahbe]

The current "disableGlobalProjectWarning" check happens after the global project warning has already been displayed, and instead serves to skip the gcloud config validation. This PR moves the check to the correct place, and puts in tests on the logged output.

Fixes #2829

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (dabbe88) to head (ac05889).
Report is 4 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #2831   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         161     161           
======================================
  Misses        161     161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rshade]

Looks good to me, thank you. I will 👍 once its a PR.

[rshade]

👍 but do we need to worry about the dotnet warnings?

[iwahbe]

👍 but do we need to worry about the dotnet warnings?

What dotnet warnings?

[rshade]

👍 but do we need to worry about the dotnet warnings?

What dotnet warnings?
There are a couple on the files page like this?

 Check warning on line 1144 in sdk/dotnet/Provider.cs


GitHub Actions
/ build_sdk / build_sdk (dotnet)

Possible null reference argument for parameter 'value' in 'Input<string>.implicit operator Input<string>(string value)'.

[iwahbe]

👍 but do we need to worry about the dotnet warnings?

What dotnet warnings?
There are a couple on the files page like this?

 Check warning on line 1144 in sdk/dotnet/Provider.cs


GitHub Actions
/ build_sdk / build_sdk (dotnet)

Possible null reference argument for parameter 'value' in 'Input<string>.implicit operator Input<string>(string value)'.

Ah. We don't need to worry about those. A codegen change is needed to fix them, and it's unrelated to this PR.

[rshade]

[pulumi-bot]

This PR has been shipped in release v8.13.1.