Note from upstream property documentation dropped

[VenelinMartinov]

What happened?

We seem to omit notes from upstream property documentation in some cases: pulumi/pulumi-gcp#2252

We should investigate if this is a conflict with our markdown parsing of upstream docs, as these can be important, like in the above case.

Example

pulumi/pulumi-gcp#2252

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[iwahbe]

@VenelinMartinov Can you link a version pinned header close to the note we should be including. I couldn't find it in the upstream docs.

[VenelinMartinov]

Added it in pulumi/pulumi-gcp#2252. Seems related to markdown parsing.

[t0yv0]

@guineveresaenger found as well pulumi/pulumi-snowflake#717

Suspecting pulumi/pulumi-aws#4921 orange-priority issue is caused by this too.

The NOTE in the AWS case is nested (property level).

[guineveresaenger]

Right.

Unfortunately on first glance I believe these are all different issues, not the same:

• Additional notes not converted to Pulumi docs pulumi-snowflake#717 is a dropped note from the Import section, which is handled separately from docs args parsing
• Compute Subnetwork secondary ip ranges drops note from upstream docs pulumi-gcp#2252 is an in-line note that is part of a type Description
• Missing important upstream documentation related to BucketReplicationConfig pulumi-aws#4921 is a note that is not part of a type Description, because upstream, this Note sits above the linked nested argument description, not inside the description for the argument itself - i.e. we do not source the type description from that part of the doc.