Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jobtype name unique per parent jobqueue #259

Open
guidow opened this issue Nov 11, 2014 · 1 comment
Open

Make jobtype name unique per parent jobqueue #259

guidow opened this issue Nov 11, 2014 · 1 comment

Comments

@guidow
Copy link
Contributor

guidow commented Nov 11, 2014

Jobtype names should be unique per parent jobqueue instead of globally across the whole system. This could allow jobqueue structures like

project 1
+- lighting
project 2
+- lighting

Unfortunately, this isn't entirely trivial because of the special case of jobqueues on the top level, which is signified by jobqueue_id=NULL. Different SQL servers treat NULL values differently inside of unique constraints – PostgreSQL treats them as always different (which is what the SQL standard says, but not very helpful for us in this case), SQL Server treats them as equal. Dunno about MySQL or SQLite.

@opalmer opalmer added this to the 0.8.0 milestone Nov 13, 2014
@opalmer
Copy link
Member

opalmer commented Nov 13, 2014

Hmm, I'd really like to avoid having to write in different behaviors per db. I wonder if we should rethink the approach our approach to 'global' some? We're likely to have this same issue in other areas where we need a global state and overrides.

guidow added a commit to guidow/pyfarm-master that referenced this issue Nov 18, 2014
They used to be globally unique

Addresses pyfarm#259
@opalmer opalmer modified the milestone: 0.8.0 Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants