From e129187203e5dd7da184cef623ac1910892ec039 Mon Sep 17 00:00:00 2001
From: jan-janssen <jan.janssen@outlook.com>
Date: Sat, 20 Jan 2024 18:44:47 +0100
Subject: [PATCH] Python compatibility

---
 .github/workflows/unittests.yml | 3 ---
 README.md                       | 1 +
 conda_subprocess/process.py     | 4 ----
 pyproject.toml                  | 3 +--
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/unittests.yml b/.github/workflows/unittests.yml
index d99ec62..9974da1 100644
--- a/.github/workflows/unittests.yml
+++ b/.github/workflows/unittests.yml
@@ -31,9 +31,6 @@ jobs:
         - operating-system: ubuntu-latest
           python-version: 3.9
 
-        - operating-system: ubuntu-latest
-          python-version: 3.8
-
     steps:
     - uses: actions/checkout@v2
     - uses: conda-incubator/setup-miniconda@v2.2.0
diff --git a/README.md b/README.md
index 87ac4bf..cc42f19 100644
--- a/README.md
+++ b/README.md
@@ -66,3 +66,4 @@ process.communicate()
 
 ## Remarks
 * The `shell` parameter and the `env` parameter are not supported in `Popen()` and all derived methods. 
+* The `pipesize` parameter and the `process_group` parameter were removed for compatibility with python 3.9. 
diff --git a/conda_subprocess/process.py b/conda_subprocess/process.py
index 87a2357..5981588 100644
--- a/conda_subprocess/process.py
+++ b/conda_subprocess/process.py
@@ -33,8 +33,6 @@ def Popen(
     errors=None,
     text=None,
     umask=-1,
-    pipesize=-1,
-    process_group=None,
 ):
     # create run script
     script, command = wrap_subprocess_call(
@@ -79,8 +77,6 @@ def Popen(
         errors=errors,
         text=text,
         umask=umask,
-        pipesize=pipesize,
-        process_group=process_group,
     )
 
 
diff --git a/pyproject.toml b/pyproject.toml
index addb966..493b13f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -11,14 +11,13 @@ authors = [
 readme = "README.md"
 license = { file = "LICENSE" }
 keywords = ["conda", "subprocess"]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 classifiers = [
     "Development Status :: 5 - Production/Stable",
     "Topic :: Utilities",
     "License :: OSI Approved :: BSD License",
     "Intended Audience :: Science/Research",
     "Operating System :: OS Independent",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",