vba_choropleth API

[darribas]

I'm taking splot out for a spin and this is great! While using vba_choropleth, it works as documented, but here are a few ideas on how the API could be made more "newbie"-ready and maybe more streamlined:

• It'd be great, if gdf contains the variables to plot, that the user could simply pass their name rather than having to "pull them out" manually. So, if x and y are in gdf, you could just pass the string with the variable name. I think the current setup is still useful in some cases, so it'd be great leaving it as an option, but I can imagine a lot of people will want to plot variables stored in the same GeoDatraFrame as the geometries.

• Maybe it's a bit redundant, but it'd be great if y was optional. This would make the method a standard choropleth, but it'd make the function more useful IMHO.

I'll drop these here for discussion, not sure everything would necessarily have to be implemented, but just food for thought.

[darribas]

One more from playing with this for a workshop this past week. It seems the function throws an error if alpha_mapclassify and rgb_mapclassify don't have a value (the default None don't seem to work). I picked this up from the example notebook, where everything is passed and it works great, but from the docs, it seems to imply that it'd be just fine by passing the variables. Is that the case? If so, happy to open up a separate issue.

[slumnitz]

@darribas yeah I think it would make sense to potentially integrate map classify into splot (which we have talked about before), offer a very high level function for plotting choropleths in all forms with one gdf and then potentially offer a couple more detailed functions?

[renanxcortes]

Hey, I'm working on this issue and I think I have a version that I'd like to show to you and started to update the docstrings. However, I realized that in some cases the function is used with 'x' before 'y' and sometimes the opposite way. Is this an issue? Wasn't supposed to be all 'x' before 'y'?

Here's the line:

splot/splot/_viz_value_by_alpha_mpl.py

Line 192 in d9a0fd1

>>> vba_choropleth(y, x, gdf, cmap='viridis', ax = axs[0,0],

[slumnitz]

fixed with #52 so closing

[darribas]

That's great! One quick question: does #52 also cover my second point (ie. enabling the user to only pass one instead of two variables)? It's my bad for including two features in one issue. If that's not the case and that'd be a useful feature, I'm happy to open it in a new issue, this time separately.

@slumnitz @renanxcortes

[darribas]

Nevermind, that is really #50