Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fixes from pyfakefs 4.0 in a Python 2.7 compatibility version. #522

Closed
marcinowski opened this issue Mar 2, 2020 · 3 comments
Closed

Comments

@marcinowski
Copy link

Is your feature request related to a problem? Please describe.
While migrating the Python 2 legacy code using pyfakefs to Python 3 I encountered some issues related to this error (#509 and #511). I can see they'll be included in the 4.0 version which drops the support for Py2

Describe the solution you'd like
Is there any chance of including some of the fixes in a 3.7.2 version that will still support Python 2?
I'm happy to assist with the 3.7.2 version if any help was needed

Describe alternatives you've considered
Otherwise I'd have to create a fork (I already did actually to test if the bug's fixed) but I assume more people would be blocked on this.

@mrbean-bremen
Copy link
Member

Sure, as long as it's only bugfixes, and someone needs them in Python 2.7, we can make patch releases for 3.7. I will have a look.

@mrbean-bremen
Copy link
Member

Ok, a new patch version has been released - please check.

@marcinowski
Copy link
Author

This is brilliant work, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants