Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentinel in namespace path breaks NamespaceReader #123987

Open
jaraco opened this issue Sep 12, 2024 · 0 comments
Open

Sentinel in namespace path breaks NamespaceReader #123987

jaraco opened this issue Sep 12, 2024 · 0 comments
Assignees
@jaraco
Labels
3.13 bugs and security fixes topic-importlib type-bug An unexpected behavior, bug, or error

Comments

@jaraco
Copy link
Member

jaraco commented Sep 12, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

As reported in python/importlib_resources#311 and highlighted by python/importlib_resources#318, when an editable install adds a sentinel value to a namespace path, it can break the NamespaceReader when that value doesn't resolve to a pathlib.Path or zipfile.Path.

This code was introduced in #106531 and fixed in importlib_resources 6.4.5.

CPython versions tested on:

3.13

Operating systems tested on:

macOS

Linked PRs
@jaraco jaraco added type-bug An unexpected behavior, bug, or error topic-importlib labels Sep 12, 2024
@jaraco jaraco self-assigned this Sep 12, 2024
@jaraco jaraco added the 3.13 bugs and security fixes label Sep 12, 2024
jaraco added a commit to jaraco/cpython that referenced this issue Sep 12, 2024
@jaraco
pythongh-123987: Fix issues in importlib.resources.
aaab6d2 
Also addresses pythongh-123085.
@bedevere-app bedevere-app bot mentioned this issue Sep 12, 2024
Merged
1 task
jaraco added a commit to jaraco/cpython that referenced this issue Sep 12, 2024
@jaraco
pythongh-123987: Fix issues in importlib.resources.
241d9e9
jaraco added a commit to jaraco/cpython that referenced this issue Sep 12, 2024
@jaraco
pythongh-123987: Fix issues in importlib.resources.
1c6608a
@jaraco jaraco mentioned this issue Jan 5, 2025
Open
jaraco added a commit to jaraco/cpython that referenced this issue Jan 26, 2025
@jaraco
Merge branch 'main' into pythongh-123987/sentinel-in-namespace-path
0f53760
jaraco added a commit that referenced this issue Jan 26, 2025
@jaraco
gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel pr…
b543b32 
…esent (#124018)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 26, 2025
@jaraco @miss-islington
pythongh-123987: Fix NotADirectoryError in NamespaceReader when senti…
2112e26 
…nel present (pythonGH-124018)

(cherry picked from commit b543b32)

Co-authored-by: Jason R. Coombs <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 26, 2025
Merged
jaraco added a commit that referenced this issue Jan 26, 2025
@miss-islington @jaraco
[3.13] gh-123987: Fix NotADirectoryError in NamespaceReader when sent…
6e88741 
…inel present (GH-124018) (#129319)

gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present (GH-124018)
(cherry picked from commit b543b32)

Co-authored-by: Jason R. Coombs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaraco jaraco

Labels
3.13 bugs and security fixes topic-importlib type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco