Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyatomic include statement shouldn't use "cpython/*" but just "*" #129296

Open
timprepscius opened this issue Jan 25, 2025 · 1 comment
Open

pyatomic include statement shouldn't use "cpython/*" but just "*" #129296

timprepscius opened this issue Jan 25, 2025 · 1 comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@timprepscius
Copy link

timprepscius commented Jan 25, 2025

Bug report

Bug description:

I'm looking at (and using) a build generated from:

  git clone --depth 1 https://github.com/python/cpython.git --branch v3.13.1

  pushd cpython

    ./configure --enable-optimizations --prefix=$(pwd)/install
    make -j4
    make install

  popd

in the file: cpython/install/include/python3.13/cpython/pyatomic.h

there is the statement

#if _Py_USE_GCC_BUILTIN_ATOMICS
#  define Py_ATOMIC_GCC_H
#  include "cpython/pyatomic_gcc.h"
#  undef Py_ATOMIC_GCC_H
#elif __STDC_VERSION__ >= 201112L && !defined(__STDC_NO_ATOMICS__)
#  define Py_ATOMIC_STD_H
#  include "cpython/pyatomic_std.h"
#  undef Py_ATOMIC_STD_H
#elif defined(_MSC_VER)
#  define Py_ATOMIC_MSC_H
#  include "cpython/pyatomic_msc.h"
#  undef Py_ATOMIC_MSC_H
#else
#  error "no available pyatomic implementation for this platform/compiler"
#endif

these includes say: include, relative to me (quotation), the file cpython/pyatomic_gcc.h

But there is no file "cpython/pyatomic_gcc.h" relative to the cypthon/pyatomic.h

I can of course compensate by putting a:
ln -s . cypthon
in that cpython directory

The fix is to change "cpython/pyatomic_gcc.h" to "pyatomic_gcc.h"
where quotation = "relative to me"

CPython versions tested on:

3.13

Operating systems tested on:

No response

Linked PRs

@timprepscius timprepscius added the type-bug An unexpected behavior, bug, or error label Jan 25, 2025
@ZeroIntensity ZeroIntensity added build The build process and cross-build 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Jan 26, 2025
@ZeroIntensity
Copy link
Member

The compiler should be falling back to the include path regardless--there's no actual compile error in practice, is there?

cc @colesbury

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants