-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2I Java (non-native) is broken since Quarkus 0.13.0 or 0.13.1 (but worked in 0.12.0) #13
Comments
we don't need a full OpenShift, this reproduces it (which BTW makes me think that we should do #14):
|
The root cause for the problem is very likely that
|
Yes, between 0.12.0 and 0.13.0+, the new bootstrap has been integrated. |
We actually always said we needed Maven 3.5.3+, so now the question is how to get an updated builder image (3.5.0 is more than 2 years old! - https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.5.0/) @tqvarnst Anything you can do? |
It's much more "fun" than that ... the Maven 3.5.0 used in |
I can think of 3 options we have here:
These are intentionally ranked in 1/2/3/4 order of preference - IMHO 1. would be simplest and best. NB: I'm not sure if upgrading the Maven version in |
4 is a no go at all, we have always said we use a recent version of Maven because of the internals of Maven that have changed and we need them (Aether is only one of them). 1 should be "easy enough" I would say. |
Got the same error today with Look the s2i () build output:
|
@rafaeltuelho it's expected, we need a new version of Maven in the image. @vorburger the Java S2I is NOT developed by Quarkus and is not in this repository. It's something that needs to be moved to the Java builder image itself. |
So, do we have any recommended workaround? |
The recently released OpenJDK 11 based on RHEL 8 use Maven 3.5.4, which should work fine with Quarkus application. After some verification, I will update the guides to use this image instead. |
@tqvarnst, I'm not sure if this was already documented... But just to add that you need some additional steps in order to perform an s2i for quarkus using the
|
The above steps worked for me just fine. But, it's not yet documented on the site: https://quarkus.io/guides/openshift-s2i-guide#deploying-the-application-as-java-application-in-openshift |
@vorburger in which repo does these guides reside? https://github.com/quarkusio/quarkusio.github.io or https://github.com/quarkusio/quarkus/tree/master/docs/src/main/asciidoc ? |
@rafaeltuelho you need to open a PR against https://github.com/quarkusio/quarkus/tree/master/docs/src/main/asciidoc. It will be merged and pushed to the web site during the release process. Can you ping me when you opened the PR? |
@cescoffier @rafaeltuelho would you open a PR ? i just been through that problem |
The issue is that the current Java S2I uses an outdated version of Maven. This is going to be handled with the new Java S2I. |
Finally just changing the default
|
This appears to be a continuing issue. I am using quarkus 1.3.0.Alpha1, |
@rsearls it works with the latest registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift (providing maven 3.6.1). Be sure to pull a recent version of the builder image. I used the image with the id: 91099d6db4c7 |
image: Declare explicit dependency on sysvinit-tools
@tqvarnst reports that the S2I Java support is broken. (That is the non-native regular pure Java one, based on the registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift S2I builder image; as documented in Deploying the application as Java application in OpenShift on https://quarkus.io/guides/openshift-s2i-guide)
I can easily locally reproduce the problem Thomas reported, but it's not trivial for me to fix it alone - let's use this issue to find the solution; I'll add more comments with an analysis and suggestions.
The text was updated successfully, but these errors were encountered: