-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus main branch build on Windows fails with internal Develocity error #42756
Comments
hey, so I just figured that what has changed is that @rsvoboda switched from installed Maven to provided Maven wrapper. When I switched back manually it seems to work. So it's not urgent anymore. Still, it seems like very minor bug. |
What version is the local maven? |
@jprinet does it ring a bell? |
I have provided information in the issue description :-) |
As @rsvoboda pointed out, what I specify is local Maven version Local Maven version
Windows Maven wrapper uses 3.9.9: My example is using Maven wrapper as steps to reproduce shows. |
Not familiar with that, let me relay it internally |
btw a Build Scan would be super helpful, could you produce one @michalvavrik ? Could you also clarify what change is responsible for the failure? |
Could you try to comment / remove the |
I'll try it tomorrow and report back. |
I have an account, but it will be harder to do on Windows. I'll check but bit busy ATM. Maybe I can report back next week and provide required context.
On our side, the difference is that when we use installed Maven 3.9.7 then it works. When we use Quarkus Maven wrapper, it doesn't. The wrapper uses 3.9.9 but it could also be related to rights? Any proper information will require time investment from me. Please be patient as I will have more time next week. |
I have the same problem. Maybe I can provide some details to help with the solution ?
or am i missing something ? |
Ok.... What I can say for now: I have Java 17 installed on the PATH and JAVA_HOME. Also, as @jprinet asked, I have removed the
|
CMD: Environment 1:
BUILD: Environment 2:
BUILD: Environment 3:
BUILD: Environment 4:
BUILD: Environment 5 (Maven Wrapper from Quarkus directory):
BUILD: I can provide build log, with -X -e, but it is too big. |
These changes solves quarkusio/quarkus#42756. What i have done to check ? 1) Made commit changes. 2) ./mvnw clean install (quarkus-project-develocity-extension, 1.1.6-SNAPSHOT to make it visible via local m2) 3) Made some changes to https://github.com/quarkusio/quarkus/blob/main/.mvn/extensions.xml, which is now looking as below: ``` <extensions> <extension> <groupId>com.gradle</groupId> <artifactId>develocity-maven-extension</artifactId> <version>1.22.2</version> </extension> <extension> <groupId>com.gradle</groupId> <artifactId>common-custom-user-data-maven-extension</artifactId> <version>2.0.1</version> </extension> <extension> <groupId>com.gradle</groupId> <artifactId>quarkus-build-caching-extension</artifactId> <version>1.8</version> </extension> <extension> <groupId>io.quarkus.develocity</groupId> <artifactId>quarkus-project-develocity-extension</artifactId> <version>1.1.6-SNAPSHOT</version> </extension> </extensions> ``` 4) cd into quarkus project git repository root directory on my disk drive 5) ./mvnw -Dquickly Result looks like that: ``` ... [INFO] Quarkus - Documentation ............................ SUCCESS [ 10.929 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 35:00 min [INFO] Finished at: 2024-10-09T17:33:10+03:00 [INFO] ------------------------------------------------------------------------ [INFO] 14725 goals, 14709 executed, 16 from cache ``` This is only way how i finally successfully built Quarkus on my Windows machine via Maven Wrapper or even locally installed Maven of version 3.9.9
@michalvavrik can you try fetch fresh main and build ? for me it's fixed now. |
@jprinet https://github.com/quarkusio/quarkus/runs/31389427792 is that what you asked for? |
Not really @lasteris, we need a CI worflow run from Could you please
to verify that you got a remote cache hit ( |
My environmental is Windows, but yes, I will do that.
|
Unfortunately, the error has returned.
How that can be truth ? So, local cache working, but remote nope ? I am sad( |
That was my fear @lasteris, as we have no clear evidence of the problem nor a fix in our latest versions. |
And yes, build successful ( i used quarkus-project-develocity-extension 1.1.6-SNAPSHOT, which i have built previously manually before my PR) Should i run a second time ? reference this:
and this
upd. 1.1.16 Error |
Hi, |
@Inithron Problem still occurs, but you can avoid this problem by applying this (disable remote cache, while it cause of problem) :
with:
|
Hi, we could not reproduce this behavior using GH actions with Windows runners. @lasteris to verify this theory, could you please run a build locally and then output the result of: |
yeah, I will do it in 4-5 hours, just wait me |
@alextu I have failed to reproduce, but remote cache even did not try to work.
Note (log details):
But all i see in problematic block is:
What am I missing ? Why remote cache even not trying to work ? |
What you see is expected:
But that's ok, even in this state, I just need to see what's in
|
PS C:\Users\asus\repo\quarkus> |
Thanks, that's very interesting indeed. |
|
@alextu About last test i think i need to tell you more details.
|
Thanks, I think I now know what's happening, can you please execute the following to confirm:
|
I am ready to do it now, but with one clarification. Your path seems not correct. if so:
and:
|
@alextu So, am I correctly understood, that root cause of problem for git on Windows, that symlinks disabled by default ? |
Yes,
To solve this issue, you must re-clone the project with |
Thank you for that investigation 💯 |
I wanted to thank you all for the time you spent on diagnosing this issue! |
Describe the bug
I build Quarkus main branch in my AWS Windows instance. Lately build started to fail over internal Develocity error. Not sure how I can disable it, I don't want leverage Develocity.
Expected behavior
Build succeeds.
Actual behavior
Build fails with:
How to Reproduce?
Steps to reproduce the issue:
Output of
uname -a
orver
Windows Server 2022
Output of
java -version
Temurin 17
Quarkus version or git rev
999-SNAPSHOT
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.9
Additional information
I'd appreciate a workaround as this is blocking me. @gsmet perhaps my build command is not valid anymore?
The text was updated successfully, but these errors were encountered: