Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Getting Started example: https://quarkus.io/guides/websockets-next-tutorial #44313

Closed
flowt-au opened this issue Nov 3, 2024 · 7 comments

Comments

@flowt-au
Copy link
Contributor

flowt-au commented Nov 3, 2024

Just looking at websockets-next and noticed the Getting Started example is using the old websocket extension. ie --extension='websockets'.

Current:

quarkus create app org.acme:websockets-quickstart \
    --extension='websockets' \
    --no-code
cd websockets-quickstart

Maybe this instead?

quarkus create app org.acme:websockets-next-quickstart \
    --extension='websockets-next' \
    --no-code
cd websockets-next-quickstart

Murray

@gsmet gsmet transferred this issue from quarkusio/extensions Nov 5, 2024
@geoand
Copy link
Contributor

geoand commented Nov 5, 2024

@flowt-au would you like to provide a PR that updates the docs?

Thanks

@flowt-au
Copy link
Contributor Author

flowt-au commented Nov 5, 2024

Sure. :-)

@geoand
Copy link
Contributor

geoand commented Nov 5, 2024

🙏

Copy link

quarkus-bot bot commented Nov 6, 2024

/cc @MichalMaler (documentation), @ebullient (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @rolfedh (documentation), @sheilamjones (documentation), @sunayna15 (documentation)

@cescoffier
Copy link
Member

@flowt-au Did you open the PR? I may have missed it.

@flowt-au
Copy link
Contributor Author

Yep. It's live. Issue can be closed. Thanks!

@cescoffier
Copy link
Member

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants