-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traces contain 'q/' part in http.route (and operation name) for system requests in 999-SNAPSHOT #45754
Comments
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
Yes, this is actually a fix as the previous path was incorrect. I need to add a note in the migration guide though. |
@gsmet the test, which detected this didn't change for several years. Was this path incorrect since 2.13? |
Yes, it was incorrect. |
@fedinskiy yeah, it has been incorrect since forever. I fixed it here: #45300 . And we probably need to discuss backporting at some point. |
FYI, I plan to push to at least 3.18. And we might want to discuss the backport to 3.15 at some point. |
I added a note in the migration guide. |
The paths were changed in quarkusio/quarkus#45300 See quarkusio/quarkus#45754 for details
The paths were changed in quarkusio/quarkus#45300 See quarkusio/quarkus#45754 for details
@gsmet you added a note regarding |
It was an example (thus the I tried to clarify things. Thanks! |
Describe the bug
I have an application, which sends traces for requests to the Jaeger instance, including system calls (with 'q/' prefix in path). In version 3.17.7 tag
http.route
of these traces contains only path after the/q
(eg/arc
), but for current Quarkus snapshot it contains the whole path (egq/arc
). This means, that we need to change our search for traces depending on the version of Quarkus used.Expected behavior
The traces should contain the path without the prefix[1] or the next version should have this behavior described as a breaking change.
[1]
Actual behavior
Traces contain the prefix
How to Reproduce?
podman run -p 16686:16686 -p 4317:4317 quay.io/jaegertracing/all-in-one:1.53.0
git clone -b no-q [email protected]:fedinskiy/reproducer.git && cd reproducer
mvn clean quarkus:dev -Dquarkus.otel.traces.suppress-non-application-uris=false -Dquarkus.otel.exporter.otlp.traces.endpoint=http://localhost:4317/api/traces -Dquarkus.application.name=old -Dquarkus.platform.version=3.17.7
curl http://localhost:8080/q/arc
mvn clean quarkus:dev -Dquarkus.otel.traces.suppress-non-application-uris=false -Dquarkus.otel.exporter.otlp.traces.endpoint=http://localhost:4317/api/traces -Dquarkus.application.name=new -Dquarkus.platform.version=999-SNAPSHOT
curl http://localhost:8080/q/arc
Output of
uname -a
orver
6.12.9-200.fc41.x86_64
Output of
java -version
23.0.1, vendor: Eclipse Adoptium
Quarkus version or git rev
5534ed1
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.6
Additional information
No response
The text was updated successfully, but these errors were encountered: