Range response status reset when using a @ServerResponseFilter

[jorsol]

Describe the bug

When returning a File Quarkus should use the ServerFileBodyHandler that supports Range requests:

quarkus/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/providers/serialisers/ServerFileBodyHandler.java

Lines 41 to 64 in 85eb353

	static void sendFile(File file, ServerRequestContext context) {
	ResteasyReactiveRequestContext ctx = ((ResteasyReactiveRequestContext) context);
	Object rangeObj = ctx.getHeader("Range", true);
	ByteRange byteRange = rangeObj == null ? null : ByteRange.parse(rangeObj.toString());
	long fileLength = file.length();
	if ((byteRange != null) && (byteRange.ranges.size() == 1)) {
	ByteRange.Range range = byteRange.ranges.get(0);
	ByteRange.Range fileRange = (range.getStart() == -1)
	? new ByteRange.Range(fileLength - range.getEnd(), fileLength - 1)
	: new ByteRange.Range(range.getStart(), Math.min(fileLength - 1, range.getEnd()));
	if ((fileRange.getStart() >= 0) && (fileRange.getStart() <= fileRange.getEnd())) {
	String contentRange = "bytes " + fileRange.getStart() + "-" + fileRange.getEnd() + "/" + fileLength;
	long length = fileRange.getEnd() - fileRange.getStart() + 1;
	context.serverResponse()
	.setStatusCode(Response.Status.PARTIAL_CONTENT.getStatusCode())
	.setResponseHeader("Content-Range", contentRange)
	.sendFile(file.getAbsolutePath(), fileRange.getStart(), length);
	return;
	}
	}
	context.serverResponse().sendFile(file.getAbsolutePath(), 0, fileLength);
	}

It works fine until I access the response from a @ServerResponseFilter where the response status is reset to 200 instead of the 206:

//usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS io.quarkus.platform:quarkus-bom:3.17.7@pom
//DEPS io.quarkus:quarkus-rest
//JAVAC_OPTIONS -parameters
//JAVA_OPTIONS -Djava.util.logging.manager=org.jboss.logmanager.LogManager

import java.io.File;

import org.jboss.resteasy.reactive.server.ServerResponseFilter;

import io.quarkus.runtime.Quarkus;
import jakarta.enterprise.context.ApplicationScoped;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.container.ContainerResponseContext;

@Path("/hello")
@ApplicationScoped
public class QuarkusApp {

  @GET
  public File sayHello() {
    return new File("/home/quarkus/data");
  }

  public static void main(String[] args) {
    Quarkus.run(args);
  }

  @ServerResponseFilter
  public void responseHeaders(ContainerResponseContext responseContext) {
    System.out.println(responseContext.getEntity());
  }

}

The ServerFileBodyHandler sets the status code to PARTIAL_CONTENT (206) .setStatusCode(Response.Status.PARTIAL_CONTENT.getStatusCode()) , but the filter is messing up this status (without even changing anything) and reset it to OK 200.

Expected behavior

❯ http :8080/hello Range:bytes=100-199
HTTP/1.1 206 Partial Content
Content-Range: bytes 100-199/10000000000
Content-Type: application/octet-stream
content-length: 100

+-----------------------------------------+
| NOTE: binary data not shown in terminal |
+-----------------------------------------+

The 206 Partial Content code should be present.

Actual behavior

❯ http :8080/hello Range:bytes=100-199
HTTP/1.1 200 OK
Content-Range: bytes 100-199/10000000000
Content-Type: application/octet-stream
content-length: 100

+-----------------------------------------+
| NOTE: binary data not shown in terminal |
+-----------------------------------------+

The 200 OK code is used instead.

How to Reproduce?

Run the QuarkusApp jbang script.

Comment the System.out.println(responseContext.getEntity()); line, and it returns 206, uncomment and it returns 200.

Any access to the response object resets the status code to 200.

Output of uname -a or ver

Linux quarkus 6.12.9-200.fc41.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Jan 9 16:05:40 UTC 2025 x86_64 GNU/Linux

Output of java -version

java 23.0.1 2024-10-15

Quarkus version or git rev

3.17.7

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.9

Additional information

No response

[quarkus-bot]

/cc @maxandersen (jbang), @quarkusio/devtools (jbang)

[geoand]

Could you please create a Maven reproduce that I can use to run the application and see the problem in action?

Thanks

[jorsol]

The reproducer is the jbang script:

//usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS io.quarkus.platform:quarkus-bom:3.17.7@pom
//DEPS io.quarkus:quarkus-rest
//JAVAC_OPTIONS -parameters
//JAVA_OPTIONS -Djava.util.logging.manager=org.jboss.logmanager.LogManager

import java.io.File;

import org.jboss.resteasy.reactive.server.ServerResponseFilter;

import io.quarkus.runtime.Quarkus;
import jakarta.enterprise.context.ApplicationScoped;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.container.ContainerResponseContext;

@Path("/hello")
@ApplicationScoped
public class QuarkusApp {

  @GET
  public File sayHello() {
    return new File("/home/quarkus/data");
  }

  public static void main(String[] args) {
    Quarkus.run(args);
  }

  @ServerResponseFilter
  public void responseHeaders(ContainerResponseContext responseContext) {
    System.out.println(responseContext.getEntity());
  }

}

[geoand]

I know, but I would really like a Maven project along with a sample data file that triggers the issue

[jorsol]

The data file is anything, could be a text file, or a binary file, it doesn't matter.

bug45791.zip

[geoand]

What size is needed? I tried with a small one and couldn't reproduce the problem

[jorsol]

./mvnw verify to the attached maven project and it triggers the problem.

[geoand]

TY

[geoand]

This will require some thought on how to address it