Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAF::FileWriter should use external diff command for large files #271

Open
gombasg opened this issue Nov 21, 2019 · 0 comments
Open

CAF::FileWriter should use external diff command for large files #271

gombasg opened this issue Nov 21, 2019 · 0 comments

Comments

@gombasg
Copy link
Contributor

gombasg commented Nov 21, 2019

We've just run into an issue with the AII dhcp plugin, where Text::Diff, invoked by CAF::FileWriter, took almost 3 hours to compute just a few lines worth of diff. Since Text::Diff is declared to be slow on large files, it would be better to call an external diff command if the inputs are large (e.g., more than 1000 lines).

Currently, the diff is computed even if it is then not going to be logged/displayed, which is inefficient. Fixing that would also be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant