Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded domain in notification logic #135

Open
jrha opened this issue Jan 14, 2025 · 3 comments
Open

Hardcoded domain in notification logic #135

jrha opened this issue Jan 14, 2025 · 3 comments
Assignees
@joaocosta
Labels
bug

Comments

@jrha
Copy link
Member

jrha commented Jan 14, 2025

6271a9d made a change to exclude clusters from notifications, but this was done by checking whether the name ends in ms.com, this obviously causes issues for other organisations.
@jrha jrha added the bug label Jan 14, 2025
@joaocosta
Copy link
Contributor

This has been fixed internally, let us run it in prod for a few days and I will resync the repository with this change.

@jrha
Copy link
Member Author

jrha commented Jan 22, 2025

Brilliant, thanks, I'm still working my way through all the changes.

@joaocosta
Copy link
Contributor

This has been fixed in joaocosta@7364e1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaocosta joaocosta

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaocosta @jrha