Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QW_CLUSTER_ENDPOINT cannot be customized #108

Closed
splix opened this issue Oct 25, 2024 · 3 comments
Closed

QW_CLUSTER_ENDPOINT cannot be customized #108

splix opened this issue Oct 25, 2024 · 3 comments

Comments

@splix
Copy link
Contributor

splix commented Oct 25, 2024

In _helpers.tpl there is the following lines:

{{- define "quickwit.environment" -}}
....
- name: QW_CLUSTER_ENDPOINT
  value: http://{{ include "quickwit.fullname" $ }}-metastore.{{ $.Release.Namespace }}.svc.cluster.local:7280
{{- range $key, $value := .Values.environment }}
- name: "{{ $key }}"
  value: "{{ $value }}"
{{- end }}
{{- end }}

Which hardcodes the cluster name as cluster.local which is not always the case, and so Quickwit doesn't work in clusters with non-default name.

It's impossible to override the value by specifying an .environment because Kubernetes takes the first value in the env list. So, right now it allows only to append a variable.

I see at least 3 ways how it can be fixed:

  1. Allows to set the cluster name. That's probably most common in other charts
  2. Do not use the cluster name at all http://{{ include "quickwit.fullname" $ }}-metastore.{{ $.Release.Namespace }}:7280 would suffice since it's not supposed to connect to an endpoint in another cluster.
  3. Move the last part (i..e, the range loop) to the top, which would allow to update any environment variable, not just append.
@guilload
Copy link
Member

I vote for 1. with cluster.local being the default value for the cluster domain. Want to open a PR?

@splix
Copy link
Contributor Author

splix commented Oct 25, 2024

Yes, I can do that

@guilload
Copy link
Member

Closed via #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants