Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vars need to consider namespaces #16

Open
quoll opened this issue Sep 27, 2023 · 0 comments
Open

Vars need to consider namespaces #16

quoll opened this issue Sep 27, 2023 · 0 comments
Assignees
@quoll
Labels
bug Something isn't working

Comments

@quoll
Copy link
Owner

quoll commented Sep 27, 2023

asami/src/asami/projection.cljc

Line 60 in 1194563

(and (symbol? x) (boolean (#{\? \%} (first (name x))))))

Only looks at the symbol name. If a namespace on a symbol exists then this should be considered instead.
Also, look at aggregate binding selection and the schema test for cars in query.clj, as these also forget namespaces
@quoll quoll added the bug Something isn't working label Sep 27, 2023
@quoll quoll self-assigned this Sep 27, 2023
@quoll quoll changed the title Carter’s needs to consider namespaces Vars need to consider namespaces Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quoll quoll

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quoll