Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rackconnect? fails on non-cloud #9

Open
martinb3 opened this issue May 14, 2015 · 0 comments
Open

rackconnect? fails on non-cloud #9

martinb3 opened this issue May 14, 2015 · 0 comments

Comments

@martinb3
Copy link
Contributor

It looks like calls to rackconnect? are failing when used on non-cloud, with error "must have rackconnect ohai plugin installed". It appears that the plugin is installed, the box just isn't a cloud box. Thus, rackconnect? should probably just return false.

Also, if node['rackspace']['foo'] or any other key is set, then it fails as well.

      def rackconnected?(node)
        return false unless node.key? 'rackspace'
        if node['rackspace'].key? 'rackconnect'
          return node['rackspace']['rackconnect']['enabled']
        else
          fail 'must have rackconnect ohai plugin installed'
        end
      end

We should be able to set node['rackspace']['foo'] and still have rackconnect? not raise or fail. Probably the source of rackspace-cookbooks/rackspace_support#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant