set(obj, key, undefined) should set the value to undefined

[AndreyYolkin]

We are investigating the ways we could safely migrate from lodash-es and use modern library with better state, support and code quality.

The only blocker we have now is the difference between set() behavior in lodash and radashi

Let's say we have object with server errors after validation:

const errors = {
  email: 'Should include @',
  entries: [{ date: 'Should be date in YYYY-MM-DD' }]
}

then i want to strip error after user provided correct date via set(errors, 'entries[0].date', undefined)

Lodash version sets value as undefined, while radashi makes early return, leaving the value untouched

I suggest to make parity between behavior in lodash and radashi in that particular case. If undefined check had been designed to just check if 3rd argument was passed, we can check arguments length instead.

I also understand this is going to be a breaking change, so we this may happen in 13.0

[aleclarson]

I approve. We're already planning on removing other nullish checks from the codebase: #70

[AndreyYolkin]

That's great! Looks like we can remove this check

radashi/src/path/set.ts

Line 17 in a6d708e

if (value === undefined) {

completely and make function even shorter. Will wait for RC to try!