Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmongVar.impose() handles already grounded variables incorrectly #46

Open
thomasleaute opened this issue Dec 13, 2020 · 0 comments
Open

Comments

@thomasleaute
Copy link

AmongVar.impose() initializes xGrounded to the number of X variables already grounded, but then calls super.impose(store), which itself calls AmongVar.queueVariable(), which again increments xGrounded for each singleton variable, resulting in each grounded variable being incorrectly counted twice.

Suggested bug fix: in AmongVar.impose(), initialize xGrounded to 0 (like is already done with yGrounded) instead of to the number of grounded variables.

@thomasleaute thomasleaute changed the title AmongVar.impose() incorrectly handles already grounded variables AmongVar.impose() handles already grounded variables incorrectly Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant