Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "no-default-features" build to CI to ensure things work w/o default feature set #283

Open
ralexstokes opened this issue Oct 10, 2023 · 5 comments
Open

add "no-default-features" build to CI to ensure things work w/o default feature set #283

ralexstokes opened this issue Oct 10, 2023 · 5 comments
Assignees
@distributedstatemachine
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ralexstokes
Copy link
Owner

we should have a build step like this in the CI to ensure that things also build w/o default features

https://github.com/ralexstokes/ssz-rs/blob/main/.github/workflows/ci.yml#L37

and it looks like beacon-api-client currently does not succeed!
@ralexstokes ralexstokes added good first issue Good for newcomers enhancement New feature or request labels Oct 10, 2023
@yash-atreya
Copy link

I can take this

@yash-atreya yash-atreya mentioned this issue Oct 11, 2023
Closed
@distributedstatemachine
Copy link
Contributor

@yash-atreya are you still working on this ? happy to take it over the line

@yash-atreya
Copy link

@yash-atreya are you still working on this ? happy to take it over the line

Please go ahead.

@ralexstokes
Copy link
Owner Author

I think we just need to do this: https://github.com/ralexstokes/ethereum-consensus/pull/284/files#r1355734863

to get that PR ready to merge -- @samtvlabs if you want to make a pass at it, feel free, otherwise I can just do in the next few days

@distributedstatemachine
Copy link
Contributor

Apologies dropped this ball on this will get this over the line this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distributedstatemachine distributedstatemachine

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ralexstokes @yash-atreya @distributedstatemachine