-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or replace all the @nuxt libraries #11302
Conversation
dd06a54
to
cf4dd1a
Compare
5d30844
to
7707757
Compare
bb26a50
to
3e5fb45
Compare
if-no-files-found: error | ||
retention-days: 10 | ||
compression-level: 9 | ||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation was wrong, bumped checkout versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, this looks good to me.
It looks like there's a minor merge conflict that needs to be resolved.
b1c3944
to
fc8212f
Compare
9494816
to
aafaee0
Compare
It looks like we are clashing with working time, so since we can test it afterward on the branch, we'll just merge it. If any issue we'll restore this part of the code or solve in Harvester I guess. |
@cnotv @rak-phillip I've tested the navigation from/to Harvester clusters and navigating Harvester pages. How to replicate:
|
|
* Update checkout to v4 and bump Node to 16 * Update GHA workflow migration paths * Removed named exports from Vue files * Move code outside of the Vue app element * Remove @nuxtjs/eslint-config-typescript * Remove @nuxt/types and @nuxt/typescript-build * Fix import issue with http-proxy-middleware * Replace @nuxtjs/axios with axios and axios-retry * Remove @nuxtjs/webpack-profile * Fix linting issues after Nuxt webpack removal * Pin resolution for glob after rebase * Update yarn.lock after rebase * Fix issue with rancher-components * Bump rancher-component GHA config to match rebase changes * Generate yarn file * Add dependency * Remove nuxt global var in app template * Pin version for babel/plugin-proposal-private-methods
* Update checkout to v4 and bump Node to 16 * Update GHA workflow migration paths * Removed named exports from Vue files * Move code outside of the Vue app element * Remove @nuxtjs/eslint-config-typescript * Remove @nuxt/types and @nuxt/typescript-build * Fix import issue with http-proxy-middleware * Replace @nuxtjs/axios with axios and axios-retry * Remove @nuxtjs/webpack-profile * Fix linting issues after Nuxt webpack removal * Pin resolution for glob after rebase * Update yarn.lock after rebase * Fix issue with rancher-components * Bump rancher-component GHA config to match rebase changes * Generate yarn file * Add dependency * Remove nuxt global var in app template * Pin version for babel/plugin-proposal-private-methods
* Update checkout to v4 and bump Node to 16 * Update GHA workflow migration paths * Removed named exports from Vue files * Move code outside of the Vue app element * Remove @nuxtjs/eslint-config-typescript * Remove @nuxt/types and @nuxt/typescript-build * Fix import issue with http-proxy-middleware * Replace @nuxtjs/axios with axios and axios-retry * Remove @nuxtjs/webpack-profile * Fix linting issues after Nuxt webpack removal * Pin resolution for glob after rebase * Update yarn.lock after rebase * Fix issue with rancher-components * Bump rancher-component GHA config to match rebase changes * Generate yarn file * Add dependency * Remove nuxt global var in app template * Pin version for babel/plugin-proposal-private-methods
Summary
Fixes #11272
Occurred changes and/or fixed issues
Technical notes summary
Strictly libraries related changes, as original plan
@nuxtjs/axios
withdefu
,axios
andaxios-retry
http-proxy-middleware
importSide effects crossed while debugging:
roarr
used in a dependency ofcy2
Updated Node version in CI to 16 for missing cases after issue on master/rebase update node version on workflows #11377This has been replaced by.nvmrc
file versioning pinning at this time.@rancher/components
due issue on compile not pointing to the right ES module after removing@nuxtjs/webpack-profile
Generic side effects:
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist