Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue3: AzureAD authentication 'enable' button stays disabled when required values are filled #11784

Closed
mantis-toboggan-md opened this issue Aug 30, 2024 · 1 comment · Fixed by #11868
Closed

Vue3: AzureAD authentication 'enable' button stays disabled when required values are filled #11784

mantis-toboggan-md opened this issue Aug 30, 2024 · 1 comment · Fixed by #11868
Assignees
@eva-vashkevich
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.10.0

Comments

@mantis-toboggan-md
Copy link
Member

Describe the bug

Form validation is not working correctly in the AzureAD auth form. The 'create' button is disabled despite all fields being populated and no errors being shown. It looks like the form requires the 'endpoint' inputs to be filled, despite being hidden unless the user switches to 'custom'

Screenshots
Screenshot 2024-08-30 at 7 26 35 AM
Screenshot 2024-08-30 at 7 28 21 AM
Screenshot 2024-08-30 at 7 28 27 AM

Additional context
Associated AzureAD unit tests should be re-enabled when this is fixed.
@mantis-toboggan-md mantis-toboggan-md added kind/bug area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Aug 30, 2024
@mantis-toboggan-md mantis-toboggan-md added this to the v2.10.0 milestone Aug 30, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 30, 2024
@mantis-toboggan-md mantis-toboggan-md mentioned this issue Aug 30, 2024
Merged
7 tasks
@eva-vashkevich eva-vashkevich mentioned this issue Sep 9, 2024
Merged
7 tasks
@yonasberhe23
Copy link
Contributor

Unit tests are sufficient. moving to done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eva-vashkevich eva-vashkevich

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Vue 3: Fixed Azure AD validation eva-vashkevich/dashboard
3 participants
@mantis-toboggan-md @yonasberhe23 @eva-vashkevich