Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish script type generation fails #11797

Closed
richard-cox opened this issue Sep 3, 2024 · 3 comments
Closed

Publish script type generation fails #11797

richard-cox opened this issue Sep 3, 2024 · 3 comments
Assignees
@mantis-toboggan-md
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.10.0

Comments

@richard-cox
Copy link
Member

Describe the bug

  • The shell/scripts/typegen.sh script creates typescript definitions that are bundled into the shell package
  • At some point (vue3?) all commands to generate types fails

https://github.com/rancher/dashboard/actions/runs/10637724977/job/29492174914

Generating typescript definitions
Generating ...
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 15: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 16: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 17: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 20: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 21: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 22: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 23: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 26: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 27: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 30: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 31: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 32: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 33: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 36: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 39: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory
/home/runner/work/dashboard/dashboard/shell/scripts/typegen.sh: line 40: /home/runner/work/dashboard/dashboard/shell/node_modules/.bin/tsc: No such file or directory

Expected Result
command succeeds, types created
@richard-cox richard-cox added kind/bug area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Sep 3, 2024
@richard-cox richard-cox added this to the v2.10.0 milestone Sep 3, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 3, 2024
@mantis-toboggan-md mantis-toboggan-md self-assigned this Sep 5, 2024
codyrancher added a commit to codyrancher/harvester that referenced this issue Sep 16, 2024
@codyrancher
Putting in some temporary workarounds regarding the typesystem
28a9001 
Without these changes we can't build the app using `yarn build-pkg harvester` because it complains about missing modules in @rancher/shell imports. I believe this will be resolved by rancher/dashboard#11797 (comment) and we should remove this change once that occurs.
@rak-phillip
Copy link
Member

Has this been resolved in #12211?

@jordojordo @aalves08

@jordojordo
Copy link
Member

@rak-phillip yes this has been fixed. Sorry I didn't realize there was a related issue.

@rak-phillip
Copy link
Member

Closing as fixed in #12211.

Duplicate of #12223.

torchiaf pushed a commit to harvester/harvester-ui-extension that referenced this issue Oct 23, 2024
@codyrancher @torchiaf
Putting in some temporary workarounds regarding the typesystem
2d26151 
Without these changes we can't build the app using `yarn build-pkg harvester` because it complains about missing modules in @rancher/shell imports. I believe this will be resolved by rancher/dashboard#11797 (comment) and we should remove this change once that occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantis-toboggan-md mantis-toboggan-md

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.10.0
Development

No branches or pull requests
4 participants
@rak-phillip @richard-cox @jordojordo @mantis-toboggan-md