Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: instances of LabeledInput using v-model.number modifier need to be updated to vue3 syntax #11856

Closed
mantis-toboggan-md opened this issue Sep 6, 2024 · 2 comments · Fixed by #11902
Assignees
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@mantis-toboggan-md
Copy link
Member

Describe the bug
It looks like v-model was generally replaced with v-model:value, but not when the .number modifier was used. UnitInputs appear to be working, but LabeledInputs using v-model.number are not. A quick code search shows we have quite a few instances of this specific problem; we can probably apply the same fix across them all in one go.

To Reproduce
The performance page garbage collection resource count input is a good example of this bug:

Screen.Recording.2024-09-06.at.10.17.36.AM.mov

Expected Result
Old uses of v-model.number need to be replaced with v-model:value.number
https://vuejs.org/guide/components/v-model.html#modifiers-for-v-model-with-arguments

@mantis-toboggan-md mantis-toboggan-md added kind/bug area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Sep 6, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 6, 2024
@IsaSih IsaSih added this to the v2.10.0 milestone Sep 9, 2024
@yonasberhe23 yonasberhe23 added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Oct 14, 2024
@yonasberhe23
Copy link
Contributor

This needs manual validation. Follow-up task created for automation rancher/qa-tasks#1589

@yonasberhe23
Copy link
Contributor

Tested the scenario in the description as well as areas pointed out in the attached pr.

Tested in:

  • Rancher 2.10-fcb4b0e12dd94e908dcc39c4f941a660f22e5d51-head
  • Dashboard master 8662b03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
3 participants