Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport v2.8.9] Fix typegen script shell directory paths #12226

Closed
github-actions bot opened this issue Oct 11, 2024 · 2 comments
Closed

[backport v2.8.9] Fix typegen script shell directory paths #12226

github-actions bot opened this issue Oct 11, 2024 · 2 comments
Assignees
@jordojordo
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None
Milestone
v2.8.9

Comments

@github-actions
Copy link
Contributor

This is a backport issue for #12223, automatically created via GitHub Actions workflow initiated by @aalves08

Original issue body:

Setup

  • Rancher version: any
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug

The publish shell workflow is not properly generating the TS types needed for the Shell package to produce a valid build of an extension. Problem lies on the Shell directory paths in the typegen script

To Reproduce

  • Check Shell workflow runs

Result

  • TS types not generated successfully

Expected Result

  • TS types should be generated successfully

Screenshots

Additional context
@github-actions github-actions bot added kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None labels Oct 11, 2024
@github-actions github-actions bot added this to the v2.8.9 milestone Oct 11, 2024
@aalves08 aalves08 mentioned this issue Oct 11, 2024
Merged
7 tasks
@gaktive
Copy link
Member

gaktive commented Oct 15, 2024

PR merged, moving to QA though no testing required.

@rancher-max
Copy link
Member

No testing required, confirmed that the shell workflow runs and produces expected ts types artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordojordo jordojordo

Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None
Projects
None yet
Milestone
v2.8.9
Development

No branches or pull requests
3 participants
@gaktive @jordojordo @rancher-max